Skip to content

Commit 006b6b6

Browse files
authored
Merge pull request #412 from vishnoianil/remove-ui
Remove UI component. It's now hosted in instructlab/ui repository
2 parents c1d8e1f + 7fd6e23 commit 006b6b6

File tree

91 files changed

+5
-6265
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

91 files changed

+5
-6265
lines changed

.ansible-lint

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
exclude_paths:
22
- compose.yaml
33
- .github/
4-
- ui/

.github/workflows/images.yml

Lines changed: 0 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -48,88 +48,6 @@ jobs:
4848
cache-to: type=gha,mode=max
4949
file: gobot/Containerfile
5050

51-
push_to_registries_ui:
52-
name: Push UI container image to GHCR
53-
runs-on: ubuntu-latest
54-
permissions:
55-
packages: write
56-
contents: read
57-
steps:
58-
- name: Check out the repo
59-
uses: actions/checkout@v4
60-
61-
- name: Log in to the Container registry
62-
uses: docker/login-action@v3
63-
with:
64-
registry: ghcr.io
65-
username: ${{ github.actor }}
66-
password: ${{ secrets.GITHUB_TOKEN }}
67-
68-
- uses: docker/setup-buildx-action@v3
69-
70-
- name: Extract metadata (tags, labels) for UI image
71-
id: ui_meta
72-
uses: docker/metadata-action@v5
73-
with:
74-
images: |
75-
ghcr.io/${{ github.repository }}/bot-ui
76-
77-
- name: Build and push ui image
78-
uses: docker/build-push-action@v6
79-
with:
80-
context: .
81-
platforms: linux/amd64,linux/arm64
82-
build-args: |
83-
GITHUB_USER=instructlab-bot
84-
GITHUB_TOKEN=${{ secrets.BOT_GITHUB_TOKEN }}
85-
push: true
86-
tags: ${{ steps.ui_meta.outputs.tags }}
87-
labels: ${{ steps.ui_meta.outputs.labels }}
88-
cache-from: type=gha
89-
cache-to: type=gha,mode=max
90-
file: ui/Containerfile
91-
92-
push_to_registries_apiserver:
93-
name: Push apiserver container image to GHCR
94-
runs-on: ubuntu-latest
95-
permissions:
96-
packages: write
97-
contents: read
98-
steps:
99-
- name: Check out the repo
100-
uses: actions/checkout@v4
101-
102-
- name: Log in to the Container registry
103-
uses: docker/login-action@v3
104-
with:
105-
registry: ghcr.io
106-
username: ${{ github.actor }}
107-
password: ${{ secrets.GITHUB_TOKEN }}
108-
109-
- uses: docker/setup-buildx-action@v3
110-
111-
- name: Extract metadata (tags, labels) for apiserver image
112-
id: apiserver_meta
113-
uses: docker/metadata-action@v5
114-
with:
115-
images: |
116-
ghcr.io/${{ github.repository }}/apiserver
117-
118-
- name: Build and push apiserver image
119-
uses: docker/build-push-action@v6
120-
with:
121-
context: .
122-
platforms: linux/amd64,linux/arm64
123-
build-args: |
124-
GITHUB_USER=instructlab-bot
125-
GITHUB_TOKEN=${{ secrets.BOT_GITHUB_TOKEN }}
126-
push: true
127-
tags: ${{ steps.apiserver_meta.outputs.tags }}
128-
labels: ${{ steps.apiserver_meta.outputs.labels }}
129-
cache-from: type=gha
130-
cache-to: type=gha,mode=max
131-
file: ui/apiserver/Containerfile
132-
13351
push_to_registries_serve:
13452
name: Push serve container image to GHCR
13553
runs-on: ubuntu-latest

.github/workflows/lint-ui.yml

Lines changed: 0 additions & 39 deletions
This file was deleted.

.markdownlint-cli2.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,3 @@ globs:
99
- "**/*.md"
1010
ignores:
1111
- "pkg"
12-
- "**/node_modules/*"
13-
- "**/node_modules/**"

CONTRIBUTING.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,10 @@ We'd also love PRs. If you're thinking of a large PR, we advise opening up an is
1717
## Submitting a pull request
1818

1919
1. [Fork][fork] and clone the repository.
20-
1. Configure and install the dependencies: `npm install`.
21-
1. Make sure the tests pass on your machine: `npm test`, note: these tests also apply the linter, so there's no need to lint separately.
22-
1. Create a new branch: `git checkout -b my-branch-name`.
23-
1. Make your change, add tests, and make sure the tests still pass.
24-
1. Push to your fork and [submit a pull request][pr].
25-
1. Pat your self on the back and wait for your pull request to be reviewed and merged.
20+
2. Create a new branch: `git checkout -b my-branch-name`.
21+
3. Make your change, add tests, and make sure the tests still pass.
22+
4. Push to your fork and [submit a pull request][pr].
23+
5. Pat your self on the back and wait for your pull request to be reviewed and merged.
2624

2725
Here are a few things you can do that will increase the likelihood of your pull request being accepted:
2826

Makefile

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,7 @@ ilabserve-base-image: worker/Containerfile.servebase ## Build container image fo
100100
$(ECHO_PREFIX) printf " %-12s worker/Containerfile.servebase\n" "[PODMAN]"
101101
$(CMD_PREFIX) podman build -f worker/Containerfile.servebase -t ghcr.io/instructlab/instructlab-bot/instructlab-serve-base:main .
102102

103-
apiserver-image: ui/apiserver/Containerfile ## Build continaer image for the Apiserver
104-
$(ECHO_PREFIX) printf " %-12s ui/apiserver/Containerfile\n" "[PODMAN]"
105-
$(CMD_PREFIX) podman build -f ui/apiserver/Containerfile -t ghcr.io/instructlab/instructlab-bot/apiserver:main .
106-
107-
ui-image: ui/Containerfile ## Build continaer image for the bot ui
108-
$(ECHO_PREFIX) printf " %-12s ui/Containerfile\n" "[PODMAN]"
109-
$(CMD_PREFIX) podman build -f ui/Containerfile -t ghcr.io/instructlab/instructlab-bot/bot-ui:main .
110-
111-
all-images: gobot-image worker-test-image apiserver-image ui-image ## Build all container images
103+
all-images: gobot-image worker-test-image ## Build all container images
112104
$(ECHO_PREFIX) printf " %-12s BUILD ALL CONTAINER IMAGES\n"
113105

114106
.PHONY: gobot
@@ -154,28 +146,12 @@ run-dev: ## Deploy the bot development stack.
154146
$(ECHO_PREFIX) printf "Deploy the development stack\n"
155147
$(CMD_PREFIX) podman compose -f ./deploy/compose/dev-single-worker-compose.yaml up -d
156148

157-
.PHONY: run-dev-ui
158-
run-dev-ui: ## Deploy the bot development stack with the UI components.
159-
$(ECHO_PREFIX) printf " %-12s \n" "[RUN DEV UI STACK]"
160-
$(CMD_PREFIX) if [ ! -f .env ]; then \
161-
echo ".env not found. Copy .env.example to .env and configure it." ; \
162-
exit 1 ; \
163-
fi
164-
$(ECHO_PREFIX) printf "Deploy the development stack with UI components\n"
165-
$(CMD_PREFIX) podman compose -f ./deploy/compose/dev-single-worker-with-ui.yaml up -d
166-
167149
.PHONY: stop-dev
168150
stop-dev: ## Stop the bot development stack.
169151
$(ECHO_PREFIX) printf " %-12s \n" "[STOP DEV STACK]"
170152
$(ECHO_PREFIX) printf "Stop the development stack\n"
171153
$(CMD_PREFIX) podman compose -f ./deploy/compose/dev-single-worker-compose.yaml down
172154

173-
.PHONY: stop-dev-ui
174-
stop-dev-ui: ## Stop the bot development stack with the UI components.
175-
$(ECHO_PREFIX) printf " %-12s \n" "[STOP DEV UI STACK]"
176-
$(ECHO_PREFIX) printf "Stop the development stack with UI components\n"
177-
$(CMD_PREFIX) podman compose -f ./deploy/compose/dev-single-worker-with-ui.yaml down
178-
179155
.PHONY: redis-stack
180156
redis-stack: ## Run a redis-stack container
181157
$(ECHO_PREFIX) printf " %-12s redis/redis-stack:latest\n" "[PODMAN]"

deploy/ansible/README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -117,14 +117,6 @@ This playbook installs all the components in the containers.
117117
ansible-playbook -i inventory.txt -e @secrets.enc --ask-vault-pass deploy-bot-stack.yml
118118
```
119119

120-
## Install the UI stack that works with the Bot stack
121-
122-
This playbook installs all the required UI components in the containers.
123-
124-
```console
125-
ansible-playbook -i inventory.txt -e @secrets.enc --ask-vault-pass deploy-ui-stack.yml
126-
```
127-
128120
## Install the Worker stack (first time installation)
129121

130122
This playbook installs all the required component on the host itself

deploy/ansible/deploy-ui-stack.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.

deploy/ansible/ui/tasks/main.yaml

Lines changed: 0 additions & 31 deletions
This file was deleted.

deploy/compose/dev-single-worker-with-ui.yaml

Lines changed: 0 additions & 58 deletions
This file was deleted.

docs/dev-env.md

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -85,38 +85,6 @@ To destroy the stack:
8585
make stop-dev
8686
```
8787

88-
## Setup local development deployment with UI components
89-
90-
If you want to deploy the bot with the UI components, you need to do the following steps:
91-
92-
1) Build the ui and apiserver images and set the `/ui/.env`. That .env file will be copied into the container at build time, it needs to be edited before building the image.
93-
94-
```text
95-
IL_UI_ADMIN_USERNAME=<ui-login-username>
96-
IL_UI_ADMIN_PASSWORD=<ui-login-password>
97-
IL_UI_API_SERVER_USERNAME=<api-server-username>
98-
IL_UI_API_SERVER_PASSWORD=<api-server-password>
99-
IL_UI_API_SERVER_URL=http://localhost:3000/jobs # Keep this as is.
100-
```
101-
102-
2) Build the images
103-
104-
```bash
105-
make all-images
106-
```
107-
108-
3) Run the stack
109-
110-
```bash
111-
make run-dev-ui
112-
```
113-
114-
To destroy the stack:
115-
116-
```bash
117-
make stop-dev-ui
118-
```
119-
12088
## Setup testing deployment
12189

12290
We use ansible for deploying this setup on the AWS cloud. To deploy this setup, you will need the following to be present on your local machine:

ui/.editorconfig

Lines changed: 0 additions & 17 deletions
This file was deleted.

ui/.env.example

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)