Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Commit 3d9c653

Browse files
committed
drm/i915: Nuke PCH_JSP
JSP is based on ICP and we don't really need to differentiate between the two. So let's just delcare JSP to be ICP. The only slight change here is for Wa_14011294188 which we used to apply for JSP but now we'll only apply to MCC. This should be fine since the issue being dealt with was introduced in TGP and inherited into MCC. JSP being derived from ICP should not need this workaround. Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Jani Nikula <[email protected]>
1 parent f24d1d4 commit 3d9c653

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

drivers/gpu/drm/i915/display/intel_display_power.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1608,7 +1608,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
16081608
gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
16091609

16101610
/* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */
1611-
if (INTEL_PCH_TYPE(dev_priv) >= PCH_JSP &&
1611+
if (INTEL_PCH_TYPE(dev_priv) >= PCH_TGP &&
16121612
INTEL_PCH_TYPE(dev_priv) < PCH_DG1)
16131613
intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D, 0,
16141614
PCH_DPMGUNIT_CLOCK_GATE_DISABLE);

drivers/gpu/drm/i915/intel_pch.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
128128
case INTEL_PCH_JSP_DEVICE_ID_TYPE:
129129
drm_dbg_kms(&dev_priv->drm, "Found Jasper Lake PCH\n");
130130
drm_WARN_ON(&dev_priv->drm, !IS_JSL_EHL(dev_priv));
131-
return PCH_JSP;
131+
/* JSP is ICP compatible */
132+
return PCH_ICP;
132133
case INTEL_PCH_ADP_DEVICE_ID_TYPE:
133134
case INTEL_PCH_ADP2_DEVICE_ID_TYPE:
134135
case INTEL_PCH_ADP3_DEVICE_ID_TYPE:

drivers/gpu/drm/i915/intel_pch.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ enum intel_pch {
2222
PCH_LPT, /* Lynxpoint/Wildcatpoint PCH */
2323
PCH_SPT, /* Sunrisepoint/Kaby Lake PCH */
2424
PCH_CNP, /* Cannon/Comet Lake PCH */
25-
PCH_ICP, /* Ice Lake PCH */
26-
PCH_JSP, /* Jasper Lake PCH */
25+
PCH_ICP, /* Ice Lake/Jasper Lake PCH */
2726
PCH_TGP, /* Tiger Lake/Mule Creek Canyon PCH */
2827
PCH_ADP, /* Alder Lake PCH */
2928

@@ -67,7 +66,6 @@ enum intel_pch {
6766
#define HAS_PCH_DG2(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG2)
6867
#define HAS_PCH_ADP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ADP)
6968
#define HAS_PCH_DG1(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_DG1)
70-
#define HAS_PCH_JSP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_JSP)
7169
#define HAS_PCH_TGP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_TGP)
7270
#define HAS_PCH_ICP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ICP)
7371
#define HAS_PCH_CNP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_CNP)

0 commit comments

Comments
 (0)