Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Commit f3c0775

Browse files
shimodaydavem330
authored andcommitted
net: ravb: Fix possible hang if RIS2_QFF1 happen
Since this driver enables the interrupt by RIC2_QFE1, this driver should clear the interrupt flag if it happens. Otherwise, the interrupt causes to hang the system. Note that this also fix a minor coding style (a comment indentation) around the fixed code. Fixes: c156633 ("Renesas Ethernet AVB driver proper") Signed-off-by: Yoshihiro Shimoda <[email protected]> Reviewed-by: Sergey Shtylyov <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c2b6cde commit f3c0775

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/renesas/ravb_main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,14 +1101,14 @@ static void ravb_error_interrupt(struct net_device *ndev)
11011101
ravb_write(ndev, ~(EIS_QFS | EIS_RESERVED), EIS);
11021102
if (eis & EIS_QFS) {
11031103
ris2 = ravb_read(ndev, RIS2);
1104-
ravb_write(ndev, ~(RIS2_QFF0 | RIS2_RFFF | RIS2_RESERVED),
1104+
ravb_write(ndev, ~(RIS2_QFF0 | RIS2_QFF1 | RIS2_RFFF | RIS2_RESERVED),
11051105
RIS2);
11061106

11071107
/* Receive Descriptor Empty int */
11081108
if (ris2 & RIS2_QFF0)
11091109
priv->stats[RAVB_BE].rx_over_errors++;
11101110

1111-
/* Receive Descriptor Empty int */
1111+
/* Receive Descriptor Empty int */
11121112
if (ris2 & RIS2_QFF1)
11131113
priv->stats[RAVB_NC].rx_over_errors++;
11141114

0 commit comments

Comments
 (0)