Skip to content

Commit 5513302

Browse files
e2e,qat4: use 'dc' 'cy' and 'generic'
Strictly speaking, 'Gen4' and 'Gen2' are wrong expressions in this case, because Gen4 resources are read as 'generic' in VMs. To prevent any confusion, use just the names of the QAT services such as 'dc', 'cy' or 'generic' Signed-off-by: Hyeongju Johannes Lee <[email protected]>
1 parent 016a57a commit 5513302

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

.github/workflows/lib-e2e.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,11 @@ jobs:
3434
runner: simics-gnr
3535
images: intel-iaa-plugin intel-idxd-config-initcontainer accel-config-demo intel-deviceplugin-operator
3636
- name: e2e-qat
37+
targetjob: e2e-qat FOCUS=Resource:generic
3738
runner: qat
3839
images: intel-qat-plugin intel-qat-initcontainer crypto-perf
3940
- name: e2e-qat4
41+
targetjob: e2e-qat FOCUS="Mode:dpdk.*Resource:(cy|dc)" SKIP=App:crypto-perf
4042
runner: simics-spr
4143
images: intel-qat-plugin intel-qat-initcontainer openssl-qat-engine
4244
- name: e2e-sgx

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,6 @@ e2e-fpga:
156156
e2e-qat:
157157
@$(GO) test -v ./test/e2e/... -ginkgo.v -ginkgo.show-node-events -ginkgo.focus "Device:qat.*$(ADDITIONAL_FOCUS_REGEX)" $(GENERATED_SKIP_OPT) -delete-namespace-on-failure=false
158158

159-
e2e-qat4:
160-
@$(GO) test -v ./test/e2e/... -ginkgo.v -ginkgo.show-node-events -ginkgo.focus "Device:qat4.*$(ADDITIONAL_FOCUS_REGEX)" $(GENERATED_SKIP_OPT) -delete-namespace-on-failure=false
161-
162159
e2e-sgx:
163160
@$(GO) test -v ./test/e2e/... -ginkgo.v -ginkgo.show-node-events -ginkgo.focus "Device:sgx.*$(ADDITIONAL_FOCUS_REGEX)" $(GENERATED_SKIP_OPT) -delete-namespace-on-failure=false
164161

test/e2e/qat/qatplugin_dpdk.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ func describeQatDpdkPlugin() {
118118
}
119119
})
120120

121-
ginkgo.Context("When QAT Gen4 resources are available with crypto (cy) services enabled [Resource:cy]", func() {
121+
ginkgo.Context("When QAT resources are available with crypto (cy) services enabled [Resource:cy]", func() {
122122
// This BeforeEach runs even before the JustBeforeEach above.
123123
ginkgo.BeforeEach(func() {
124124
ginkgo.By("creating a configMap before plugin gets deployed")
@@ -146,7 +146,7 @@ func describeQatDpdkPlugin() {
146146
})
147147
})
148148

149-
ginkgo.Context("When QAT Gen4 resources are available with compress (dc) services enabled [Resource:dc]", func() {
149+
ginkgo.Context("When QAT resources are available with compress (dc) services enabled [Resource:dc]", func() {
150150
ginkgo.BeforeEach(func() {
151151
ginkgo.By("creating a configMap before plugin gets deployed")
152152
e2ekubectl.RunKubectlOrDie(f.Namespace.Name, "create", "configmap", "--from-literal", "qat.conf=ServicesEnabled=dc", "qat-config")
@@ -164,9 +164,9 @@ func describeQatDpdkPlugin() {
164164
})
165165
})
166166

167-
ginkgo.Context("When QAT Gen2 resources are available [Resource:generic]", func() {
167+
ginkgo.Context("When QAT resources are available [Resource:generic]", func() {
168168
ginkgo.BeforeEach(func() {
169-
ginkgo.By("setting resourceName for Gen2 resources")
169+
ginkgo.By("setting resourceName for generic resources")
170170
resourceName = "qat.intel.com/generic"
171171
})
172172

0 commit comments

Comments
 (0)