Skip to content

Commit 8a127c1

Browse files
committed
golanci-lint: upgrade to 1.60.3, fix one issue and ignore conversion errors
Signed-off-by: Tuomas Katila <[email protected]>
1 parent 8625c5a commit 8a127c1

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

Diff for: .github/workflows/lib-validate.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
- name: golangci-lint
4343
uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6
4444
with:
45-
version: v1.57.2
45+
version: v1.60.3
4646
args: -v --timeout 5m
4747
build:
4848
name: Build and check device plugins

Diff for: .golangci.yml

+5-2
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ linters:
1212
- bodyclose
1313
- dogsled
1414
- errcheck
15-
- exportloopref
15+
- copyloopvar
1616
- gocognit
1717
- goconst
1818
- gocyclo
1919
- godot
20-
- goerr113
20+
- err113
2121
- gofmt
2222
- goimports
2323
- gomodguard
@@ -62,6 +62,9 @@ linters-settings:
6262

6363
issues:
6464
exclude-rules:
65+
- linters:
66+
- gosec
67+
text: "G115"
6568
- path: _test\.go
6669
linters:
6770
- gocognit

Diff for: Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ EXTRA_BUILD_ARGS ?= ""
1010

1111
CERT_MANAGER_VERSION ?= v1.15.2
1212
CONTROLLER_GEN_VERSION ?= v0.16.1
13-
GOLANGCI_LINT_VERSION ?= v1.57.2
13+
GOLANGCI_LINT_VERSION ?= v1.60.3
1414
KIND_VERSION ?= v0.23.0
1515
GOLICENSES_VERSION ?= v1.6.0
1616
# Default bundle image tag

Diff for: cmd/internal/labeler/labeler_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,6 @@ func TestLabeling(t *testing.T) {
638638
t.Fatalf("can't create temporary subroot directory: %+v", err)
639639
}
640640

641-
tc := tc
642641
t.Run(tc.name, func(t *testing.T) {
643642
err := os.MkdirAll(path.Join(subroot, "0"), 0750)
644643
if err != nil {

0 commit comments

Comments
 (0)