Skip to content

Commit eb88c82

Browse files
hj-johannes-leehj-johannes-lee
committed
operator, test: Add unit tests for cpu/memory requests and limits
Signed-off-by: Hyeongju Johannes Lee <[email protected]>
1 parent 8f576fc commit eb88c82

File tree

7 files changed

+77
-0
lines changed

7 files changed

+77
-0
lines changed

Diff for: ‎pkg/controllers/dlb/controller_test.go

+11
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121

2222
apps "k8s.io/api/apps/v1"
2323
v1 "k8s.io/api/core/v1"
24+
"k8s.io/apimachinery/pkg/api/resource"
2425
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2526
"k8s.io/apimachinery/pkg/util/diff"
2627
"k8s.io/apimachinery/pkg/util/intstr"
@@ -92,6 +93,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
9293
ReadOnlyRootFilesystem: &yes,
9394
AllowPrivilegeEscalation: &no,
9495
},
96+
Resources: v1.ResourceRequirements{
97+
Limits: v1.ResourceList{
98+
v1.ResourceCPU: resource.MustParse("100m"),
99+
v1.ResourceMemory: resource.MustParse("30Mi"),
100+
},
101+
Requests: v1.ResourceList{
102+
v1.ResourceCPU: resource.MustParse("40m"),
103+
v1.ResourceMemory: resource.MustParse("15Mi"),
104+
},
105+
},
95106
VolumeMounts: []v1.VolumeMount{
96107
{
97108
Name: "devfs",

Diff for: ‎pkg/controllers/dsa/controller_test.go

+11
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020

2121
apps "k8s.io/api/apps/v1"
2222
v1 "k8s.io/api/core/v1"
23+
"k8s.io/apimachinery/pkg/api/resource"
2324
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2425
"k8s.io/apimachinery/pkg/util/diff"
2526
"k8s.io/apimachinery/pkg/util/intstr"
@@ -96,6 +97,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
9697
ReadOnlyRootFilesystem: &yes,
9798
AllowPrivilegeEscalation: &no,
9899
},
100+
Resources: v1.ResourceRequirements{
101+
Limits: v1.ResourceList{
102+
v1.ResourceCPU: resource.MustParse("100m"),
103+
v1.ResourceMemory: resource.MustParse("50Mi"),
104+
},
105+
Requests: v1.ResourceList{
106+
v1.ResourceCPU: resource.MustParse("50m"),
107+
v1.ResourceMemory: resource.MustParse("25Mi"),
108+
},
109+
},
99110
VolumeMounts: []v1.VolumeMount{
100111
{
101112
Name: "devfs",

Diff for: ‎pkg/controllers/fpga/controller_test.go

+11
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121

2222
apps "k8s.io/api/apps/v1"
2323
v1 "k8s.io/api/core/v1"
24+
"k8s.io/apimachinery/pkg/api/resource"
2425
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2526
"k8s.io/apimachinery/pkg/util/diff"
2627
"k8s.io/apimachinery/pkg/util/intstr"
@@ -94,6 +95,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
9495
AllowPrivilegeEscalation: &no,
9596
},
9697
TerminationMessagePath: "/tmp/termination-log",
98+
Resources: v1.ResourceRequirements{
99+
Limits: v1.ResourceList{
100+
v1.ResourceCPU: resource.MustParse("160m"),
101+
v1.ResourceMemory: resource.MustParse("60Mi"),
102+
},
103+
Requests: v1.ResourceList{
104+
v1.ResourceCPU: resource.MustParse("80m"),
105+
v1.ResourceMemory: resource.MustParse("30Mi"),
106+
},
107+
},
97108
VolumeMounts: []v1.VolumeMount{
98109
{
99110
MountPath: "/dev",

Diff for: ‎pkg/controllers/gpu/controller_test.go

+11
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222

2323
apps "k8s.io/api/apps/v1"
2424
v1 "k8s.io/api/core/v1"
25+
"k8s.io/apimachinery/pkg/api/resource"
2526
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2627
"k8s.io/apimachinery/pkg/util/diff"
2728
"k8s.io/apimachinery/pkg/util/intstr"
@@ -105,6 +106,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
105106
ReadOnlyRootFilesystem: &yes,
106107
AllowPrivilegeEscalation: &no,
107108
},
109+
Resources: v1.ResourceRequirements{
110+
Limits: v1.ResourceList{
111+
v1.ResourceCPU: resource.MustParse("100m"),
112+
v1.ResourceMemory: resource.MustParse("90Mi"),
113+
},
114+
Requests: v1.ResourceList{
115+
v1.ResourceCPU: resource.MustParse("40m"),
116+
v1.ResourceMemory: resource.MustParse("45Mi"),
117+
},
118+
},
108119
VolumeMounts: []v1.VolumeMount{
109120
{
110121
Name: "devfs",

Diff for: ‎pkg/controllers/iaa/controller_test.go

+11
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020

2121
apps "k8s.io/api/apps/v1"
2222
v1 "k8s.io/api/core/v1"
23+
"k8s.io/apimachinery/pkg/api/resource"
2324
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2425
"k8s.io/apimachinery/pkg/util/diff"
2526
"k8s.io/apimachinery/pkg/util/intstr"
@@ -96,6 +97,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
9697
ReadOnlyRootFilesystem: &yes,
9798
AllowPrivilegeEscalation: &no,
9899
},
100+
Resources: v1.ResourceRequirements{
101+
Limits: v1.ResourceList{
102+
v1.ResourceCPU: resource.MustParse("120m"),
103+
v1.ResourceMemory: resource.MustParse("50Mi"),
104+
},
105+
Requests: v1.ResourceList{
106+
v1.ResourceCPU: resource.MustParse("60m"),
107+
v1.ResourceMemory: resource.MustParse("25Mi"),
108+
},
109+
},
99110
VolumeMounts: []v1.VolumeMount{
100111
{
101112
Name: "devfs",

Diff for: ‎pkg/controllers/qat/controller_test.go

+11
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121

2222
apps "k8s.io/api/apps/v1"
2323
v1 "k8s.io/api/core/v1"
24+
"k8s.io/apimachinery/pkg/api/resource"
2425
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2526
"k8s.io/apimachinery/pkg/util/diff"
2627
"k8s.io/apimachinery/pkg/util/intstr"
@@ -100,6 +101,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
100101
ReadOnlyRootFilesystem: &yes,
101102
AllowPrivilegeEscalation: &no,
102103
},
104+
Resources: v1.ResourceRequirements{
105+
Limits: v1.ResourceList{
106+
v1.ResourceCPU: resource.MustParse("140m"),
107+
v1.ResourceMemory: resource.MustParse("30Mi"),
108+
},
109+
Requests: v1.ResourceList{
110+
v1.ResourceCPU: resource.MustParse("70m"),
111+
v1.ResourceMemory: resource.MustParse("15Mi"),
112+
},
113+
},
103114
VolumeMounts: []v1.VolumeMount{
104115
{
105116
Name: "devdir",

Diff for: ‎pkg/controllers/sgx/controller_test.go

+11
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121

2222
apps "k8s.io/api/apps/v1"
2323
v1 "k8s.io/api/core/v1"
24+
"k8s.io/apimachinery/pkg/api/resource"
2425
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2526
"k8s.io/apimachinery/pkg/util/diff"
2627
"k8s.io/apimachinery/pkg/util/intstr"
@@ -88,6 +89,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
8889
ReadOnlyRootFilesystem: &yes,
8990
AllowPrivilegeEscalation: &no,
9091
},
92+
Resources: v1.ResourceRequirements{
93+
Limits: v1.ResourceList{
94+
v1.ResourceCPU: resource.MustParse("100m"),
95+
v1.ResourceMemory: resource.MustParse("30Mi"),
96+
},
97+
Requests: v1.ResourceList{
98+
v1.ResourceCPU: resource.MustParse("40m"),
99+
v1.ResourceMemory: resource.MustParse("15Mi"),
100+
},
101+
},
91102
VolumeMounts: []v1.VolumeMount{
92103
{
93104
Name: "kubeletsockets",

0 commit comments

Comments
 (0)