Skip to content

Commit 4568422

Browse files
authored
[Coverity][UR] Remove noexcept keywords from pool_manager methods (#17678)
This should fix coverity issues in `ur_pool_manager.hpp`, `ur_util.hpp` and `ur_adapter_registry.hpp` files reported in: https://coverity.devtools.intel.com/prod6/#/project-view/26752/10020
1 parent ca2af37 commit 4568422

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

unified-runtime/source/common/ur_pool_manager.hpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ template <typename D, typename H> struct pool_manager {
174174
return {UR_RESULT_SUCCESS, std::move(manager)};
175175
}
176176

177-
ur_result_t addPool(const D &desc, unique_pool_handle_t &&hPool) noexcept {
177+
ur_result_t addPool(const D &desc, unique_pool_handle_t &&hPool) {
178178
if (!descToPoolMap.try_emplace(desc, std::move(hPool)).second) {
179179
logger::error("Pool for pool descriptor: {}, already exists", desc);
180180
return UR_RESULT_ERROR_INVALID_ARGUMENT;
@@ -183,7 +183,7 @@ template <typename D, typename H> struct pool_manager {
183183
return UR_RESULT_SUCCESS;
184184
}
185185

186-
std::optional<pool_handle_t> getPool(const D &desc) noexcept {
186+
std::optional<pool_handle_t> getPool(const D &desc) {
187187
auto it = descToPoolMap.find(desc);
188188
if (it == descToPoolMap.end()) {
189189
logger::error("Pool descriptor doesn't match any existing pool: {}",
@@ -193,7 +193,7 @@ template <typename D, typename H> struct pool_manager {
193193

194194
return it->second.get();
195195
}
196-
template <typename Func> void forEachPool(Func func) noexcept {
196+
template <typename Func> void forEachPool(Func func) {
197197
for (const auto &[desc, pool] : descToPoolMap) {
198198
if (!func(pool.get()))
199199
break;

0 commit comments

Comments
 (0)