Skip to content

Commit e8cb3de

Browse files
committed
[UR] Remove setting redundant OUTPUT_NAMEs
Looks like combining `DEBUG_POSTFIX=d` and then setting `LIBRARY_OUTPUT_NAME`/`RUNTIME_OUTPUT_NAME` exposes a bug in CMake where the `DEBUG_POSTFIX` is ignored for the `ur_loader.dll`. Removing these redundant propert setters fixed the previous issue.
1 parent c89b542 commit e8cb3de

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

unified-runtime/cmake/helpers.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ function(add_ur_library name)
207207
)
208208
endif()
209209
if(UR_USE_DEBUG_POSTFIX)
210-
set_target_properties(${name} PROPERTIES OUTPUT_NAME ${name}d)
210+
set_target_properties(${name} PROPERTIES DEBUG_POSTFIX d)
211211
endif()
212212
if(UR_EXTERNAL_DEPENDENCIES)
213213
add_dependencies(${name} ${UR_EXTERNAL_DEPENDENCIES})

unified-runtime/source/loader/CMakeLists.txt

-5
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux")
4343
target_link_options(ur_loader PRIVATE "-Wl,--version-script=${LOADER_VERSION_SCRIPT}")
4444
endif()
4545

46-
set_target_properties(ur_loader PROPERTIES
47-
LIBRARY_OUTPUT_NAME ur_loader
48-
RUNTIME_OUTPUT_NAME ur_loader
49-
)
50-
5146
add_library(${PROJECT_NAME}::loader ALIAS ur_loader)
5247

5348
target_include_directories(ur_loader PRIVATE

0 commit comments

Comments
 (0)