tinycrypt/hmac: Array compared to NULL has no effect

Ramakrishna Pallala · Ramakrishna Pallala · commit 3e4e536c33f9 · 2017-08-29T08:09:08.000-04:00
This commit fixes the issue reported by Coverity: an array compared
against NULL is always false.

Signed-off-by: Ramakrishna Pallala &lt;ramakrishna.pallala@intel.com&gt;
diff --git a/lib/source/hmac.c b/lib/source/hmac.c
@@ -97,8 +97,7 @@ int tc_hmac_init(TCHmacState_t ctx)
 {
 
 	/* input sanity check: */
-	if (ctx == (TCHmacState_t) 0 ||
-      	    ctx->key == (uint8_t *) 0) {
+	if (ctx == (TCHmacState_t) 0) {
 		return TC_CRYPTO_FAIL;
 	}
 
@@ -114,8 +113,7 @@ int tc_hmac_update(TCHmacState_t ctx,
 {
 
 	/* input sanity check: */
-	if (ctx == (TCHmacState_t) 0 ||
-	    ctx->key == (uint8_t *) 0) {
+	if (ctx == (TCHmacState_t) 0) {
 		return TC_CRYPTO_FAIL;
 	}
 
@@ -130,8 +128,7 @@ int tc_hmac_final(uint8_t *tag, unsigned int taglen, TCHmacState_t ctx)
 	/* input sanity check: */
 	if (tag == (uint8_t *) 0 ||
 	    taglen != TC_SHA256_DIGEST_SIZE ||
-	    ctx == (TCHmacState_t) 0 ||
-	    ctx->key == (uint8_t *) 0) {
+	    ctx == (TCHmacState_t) 0) {
 		return TC_CRYPTO_FAIL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,7 @@ int tc_hmac_init(TCHmacState_t ctx)`
`97`	`97`	`{`
`98`	`98`
`99`	`99`	`/* input sanity check: */`
`100`		`- if (ctx == (TCHmacState_t) 0 \|\|`
`101`		`- ctx->key == (uint8_t *) 0) {`
	`100`	`+ if (ctx == (TCHmacState_t) 0) {`
`102`	`101`	`return TC_CRYPTO_FAIL;`
`103`	`102`	`}`
`104`	`103`
`@@ -114,8 +113,7 @@ int tc_hmac_update(TCHmacState_t ctx,`
`114`	`113`	`{`
`115`	`114`
`116`	`115`	`/* input sanity check: */`
`117`		`- if (ctx == (TCHmacState_t) 0 \|\|`
`118`		`- ctx->key == (uint8_t *) 0) {`
	`116`	`+ if (ctx == (TCHmacState_t) 0) {`
`119`	`117`	`return TC_CRYPTO_FAIL;`
`120`	`118`	`}`
`121`	`119`
`@@ -130,8 +128,7 @@ int tc_hmac_final(uint8_t *tag, unsigned int taglen, TCHmacState_t ctx)`
`130`	`128`	`/* input sanity check: */`
`131`	`129`	`if (tag == (uint8_t *) 0 \|\|`
`132`	`130`	`taglen != TC_SHA256_DIGEST_SIZE \|\|`
`133`		`- ctx == (TCHmacState_t) 0 \|\|`
`134`		`- ctx->key == (uint8_t *) 0) {`
	`131`	`+ ctx == (TCHmacState_t) 0) {`
`135`	`132`	`return TC_CRYPTO_FAIL;`
`136`	`133`	`}`
`137`	`134`