tinycrypt/hmac: Array compared to NULL has no effect

This commit fixes the issue reported by Coverity: an array compared against NULL is always false. Signed-off-by: Ramakrishna Pallala <[email protected]>
intel · Aug 29, 2017 · 3e4e536 · 3e4e536
1 parent 7c7e5c6
commit 3e4e536
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/lib/source/hmac.c b/lib/source/hmac.c
@@ -97,8 +97,7 @@ int tc_hmac_init(TCHmacState_t ctx)
 {
 
 	/* input sanity check: */
-	if (ctx == (TCHmacState_t) 0 ||
-      	    ctx->key == (uint8_t *) 0) {
+	if (ctx == (TCHmacState_t) 0) {
 		return TC_CRYPTO_FAIL;
 	}
 
@@ -114,8 +113,7 @@ int tc_hmac_update(TCHmacState_t ctx,
 {
 
 	/* input sanity check: */
-	if (ctx == (TCHmacState_t) 0 ||
-	    ctx->key == (uint8_t *) 0) {
+	if (ctx == (TCHmacState_t) 0) {
 		return TC_CRYPTO_FAIL;
 	}
 
@@ -130,8 +128,7 @@ int tc_hmac_final(uint8_t *tag, unsigned int taglen, TCHmacState_t ctx)
 	/* input sanity check: */
 	if (tag == (uint8_t *) 0 ||
 	    taglen != TC_SHA256_DIGEST_SIZE ||
-	    ctx == (TCHmacState_t) 0 ||
-	    ctx->key == (uint8_t *) 0) {
+	    ctx == (TCHmacState_t) 0) {
 		return TC_CRYPTO_FAIL;
 	}