Encoding thumbnail urls

internetarchive · Oct 4, 2024 · f039ff1 · f039ff1
1 parent fa018e3
commit f039ff1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/iiify/resolver.py b/iiify/resolver.py
@@ -497,7 +497,7 @@ def addThumbnails(manifest, identifier, files):
                 mimetype = "image/png"
 
             thumbnails.append({
-                "id": f"{ARCHIVE}/download/{identifier}/{file['name']}",
+                "id": f"{ARCHIVE}/download/{quote(identifier)}/{quote(file['name'])}",
                 "type": "Image",
                 "format": mimetype,
             })

diff --git a/tests/test_manifests.py b/tests/test_manifests.py
@@ -145,6 +145,14 @@ def test_multi_file(self):
         manifest = resp.json
         self.assertEqual(len(manifest['items']),6, f"Expected five canvases, but got {len(manifest['items'])}")
 
+    def test_encoded_thumb(self):    
+        resp = self.test_app.get("/iiif/3/steamboat-willie-16mm-film-scan-4k-lossless/manifest.json")
+        self.assertEqual(resp.status_code, 200)
+        manifest = resp.json
+        self.assertEqual(len(manifest['thumbnail']),15, f"Expected 15 thumbnails, but got {len(manifest['items'])}")
+        self.assertEqual(manifest['thumbnail'][0]['id'],"https://archive.org/download/steamboat-willie-16mm-film-scan-4k-lossless/steamboat-willie-16mm-film-scan-4k-lossless.thumbs/Steamboat%20Willie%20%5B16mm%20Film%20Scan%5D_ProRes%20%283400x2550%29_000001.jpg", f"Expected URL to be encoded")
+
+
 
 ''' to test:
 kaled_jalil (no derivatives)