Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test reports on dev-docker.batch should be publicly accessible with a direct link #1321

Closed
stitch opened this issue Mar 11, 2024 · 4 comments
Labels
bug Unexpected or unwanted behaviour of current implementations release blocker Issues that must be resolved before an upcoming version can be released

Comments

@stitch
Copy link
Collaborator

stitch commented Mar 11, 2024

A report like the following is linked on the dashboard next to the metrics. This link is used to view the entire test report. This works fine on production but on the new batch environment a login screen is presented. The links to these reports should be publicly accessible in some way.

Example of report where login is shown on acc:
http://dev-docker.batch.internet.nl/site/20072020.europaomdehoek.nl/19067/

Example where the result is public:
https://batch.internet.nl/mail/2017.jaarverslaghogeraad.nl/7680087/

The link is used on (public) reports here, see the internet.nl icon on the left:
image

Authenticated users of the dashboard are also presented the credential screen, which can be very annoying (although probably one time given it is htaccess).

@stitch stitch added the bug Unexpected or unwanted behaviour of current implementations label Mar 11, 2024
@mxsasha
Copy link
Collaborator

mxsasha commented Mar 11, 2024

Oh, this is an intentional feature for #1274 #1286, which I have currently deployed on dev-docker.batch. We decided there we should limit access to all URLs, so I guess that was wrong. We should refine this.

@mxsasha mxsasha added discuss Requires further team discussion and decisions release blocker Issues that must be resolved before an upcoming version can be released labels Mar 11, 2024
@bwbroersma
Copy link
Collaborator

bwbroersma commented Mar 11, 2024

I think the final conclusion about #1274 was to make the basic authentication the same as the current non-docker situation. But it's a bit ambiguous because I did strike-trough of "Some parts should be always accessible", because it's already the current non-docker batch situation.

$ curl 'https://{,dev.,dev-docker.}batch.internet.nl/site/a/1/' -sSw '%{http_code}\t%{url_effective}\n' -o/dev/null
302	https://batch.internet.nl/site/a/1/
302	https://dev.batch.internet.nl/site/a/1/
401	https://dev-docker.batch.internet.nl/site/a/1/

@mxsasha
Copy link
Collaborator

mxsasha commented Mar 11, 2024

Note that dev-docker.batch has the branch for #1274 currently deployed, so displays the behaviour that we thought we wanted in #1274, but have now found not to work. So dev-docker.batch does not reflect current main branch. Your curl is intentional expected behaviour in the original #1274 requirements. Let's make sure we have all details pinned down in that issue.

@mxsasha mxsasha removed the discuss Requires further team discussion and decisions label Mar 19, 2024
@mxsasha
Copy link
Collaborator

mxsasha commented Mar 26, 2024

Closed through #1274

@mxsasha mxsasha closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected or unwanted behaviour of current implementations release blocker Issues that must be resolved before an upcoming version can be released
Development

No branches or pull requests

3 participants