Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated peer dependency with Typeorm #46

Open
SishaarRao opened this issue Jan 12, 2023 · 1 comment
Open

Outdated peer dependency with Typeorm #46

SishaarRao opened this issue Jan 12, 2023 · 1 comment

Comments

@SishaarRao
Copy link

TypeORM is now on version 0.3.11. Due to this library's peer dependency, this means that the package is no longer compatible with the latest version of TypeORM.

We should upgrade the TypeORM dependency and make any fixes if necessary.

@SishaarRao
Copy link
Author

SishaarRao commented Jan 12, 2023

@gboston Happy to make a pull request for this, however I'm unable to push my branch to the repository.

Only change needed to be made is to change the package.json file to the following. Looks like no tests needed to be updated, at least when I did this locally

{
  "name": "fastify-typeorm-plugin",
  "version": "3.0.0",
  "description": "Fastify plugin for typeorm",
  "main": "index.js",
  "scripts": {
    "lint": "standard | snazzy",
    "unit": "tap test.js",
    "test": "npm run lint && npm run unit"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/inthepocket/fastify-typeorm-plugin.git"
  },
  "keywords": [
    "fastify",
    "typeorm"
  ],
  "author": "Team Nebula",
  "license": "MIT",
  "bugs": {
    "url": "https://github.com/inthepocket/fastify-typeorm-plugin/issues"
  },
  "homepage": "https://github.com/inthepocket/fastify-typeorm-plugin#readme",
  "dependencies": {
    "fastify-plugin": "^3.0.0"
  },
  "peerDependencies": {
    "typeorm": "^0.3.11"
  },
  "devDependencies": {
    "fastify": "^3.0.3",
    "pg": "^8.0.0",
    "pre-commit": "^1.2.2",
    "snazzy": "^9.0.0",
    "standard": "^16.0.3",
    "tap": "^15.0.9"
  }
}

Note the changed lines

  "version": "3.0.0",

and

  "peerDependencies": {
    "typeorm": "^0.3.11"
  },

After merging the PR, the new major version would need to be published as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant