Removing var_dumps

As @alexjeen mentioned there’s var_dump’s and echo’s in  the code that really shouldn’t be there. So this commit removes them and switches to the custom logger.

Author: challgren

src/Core/Http/Serialization/XmlObjectSerializer.php

@@ -36,8 +36,8 @@ class XmlObjectSerializer extends IEntitySerializer
     private static function getXmlFromObj($phpObj)
     {
         if (!$phpObj) {
-            echo "getXmlFromObj NULL arg\n";
-            var_dump(debug_backtrace());
+            $this->IDSLogger->CustomLogger->Log(TraceLevel::Error, "Encountered an error parsing the xmlFromObj.");
+            $this->IDSLogger->CustomLogger->Log(TraceLevel::Error, "Stack Trace: " . implode("\n", debug_backtrace()));
             return false;
         }
 
@@ -47,11 +47,9 @@ private static function getXmlFromObj($phpObj)
         try {
             return $php2xml->getXml($phpObj);
         } catch (\Exception $e) {
-            echo "\n"."Object Dump:\n";
-            var_dump($phpObj);
-            echo "\n"."Exception Call Stack (".$e->getMessage()."):\n";
-            echo "\n"."In  (".$e->getFile().") on " . $e->getLine();
-            array_walk(debug_backtrace(), create_function('$a,$b', 'print "\t{$a[\'function\']}()\n\t".basename($a[\'file\']).":{$a[\'line\']}\n";'));
+            $this->IDSLogger->CustomLogger->Log(TraceLevel::Error, "Encountered an error parsing the batch response." . $e->getMessage());
+            $this->IDSLogger->CustomLogger->Log(TraceLevel::Error, "Object: " . var_export($phpObj, true));
+            $this->IDSLogger->CustomLogger->Log(TraceLevel::Error, "Stack Trace: " . $e->getTraceAsString());
             return false;
         }
     }

src/DataService/Batch.php

@@ -335,7 +335,8 @@ public function Execute()
                 $this->intuitBatchItemResponses[$intuitBatchItemResponse->batchItemId] = $intuitBatchItemResponse;
             }
         } catch (\Exception $e) {
-            var_dump($e->getMessage(), $e->getLine());
+            $this->serviceContext->IppConfiguration->Logger->CustomLogger->Log(TraceLevel::Error, "Encountered an error parsing the batch response." . $e->getMessage());
+            $this->serviceContext->IppConfiguration->Logger->CustomLogger->Log(TraceLevel::Error, "Stack Trace: " . $e->getTraceAsString());
             return null;
         }
 

src/DataService/DataService.php

@@ -458,7 +458,8 @@ public function updateOAuth2Token($newOAuth2AccessToken)
           $this->serviceContext->realmId = $realmID;
           $this->setupRestHandler($this->serviceContext);
         } catch (SdkException $e){
-          echo $e->getTraceAsString();
+            $this->serviceContext->IppConfiguration->Logger->CustomLogger->Log(TraceLevel::Error, "Encountered an error while updating OAuth2Token." . $e->getMessage());
+            $this->serviceContext->IppConfiguration->Logger->CustomLogger->Log(TraceLevel::Error, "Stack Trace: " . $e->getTraceAsString());
         }
         return $this;
     }
@@ -538,9 +539,8 @@ protected function getRequestSerializer()
     private function getXmlFromObj($phpObj)
     {
         if (!$phpObj) {
-            echo "getXmlFromObj NULL arg\n";
-            var_dump(debug_backtrace());
-
+            $this->serviceContext->IppConfiguration->Logger->CustomLogger->Log(TraceLevel::Error, "getXmlFromObj NULL arg.");
+            
             return false;
         }
 
@@ -550,9 +550,8 @@ private function getXmlFromObj($phpObj)
         try {
             return $php2xml->getXml($phpObj);
         } catch (\Exception $e) {
-            echo "getXmlFromObj EXCEPTION: " . $e->getMessage() . "\n";
-            var_dump($phpObj);
-            var_dump(debug_backtrace());
+            $this->serviceContext->IppConfiguration->Logger->CustomLogger->Log(TraceLevel::Error, "Encountered an error parsing Object to XML." . $e->getMessage());
+            $this->serviceContext->IppConfiguration->Logger->CustomLogger->Log(TraceLevel::Error, "Stack Trace: " . $e->getTraceAsString());
 
             return false;
         }
@@ -1000,9 +999,8 @@ public function Query($query, $startPosition = null, $maxResults = null)
                     $tmpXML = $responseXmlObj->QueryResponse->asXML();
                 }
                 $parsedResponseBody = $this->responseSerializer->Deserialize($tmpXML, false);
-                //echo "Parsed Body is: \n";
-                //var_dump($parsedResponseBody);
-                //echo "\n Parsed Body over.\n";
+                $this->serviceContext->IppConfiguration->Logger->CustomLogger->Log(TraceLevel::Info, $parsedResponseBody);
+                
             } catch (\Exception $e) {
                 throw new \Exception("Exception appears in converting Response to XML.");
             }

src/Utility.Test/JsonObjectSerializerTest.php

@@ -75,8 +75,7 @@ public function testDeserializerTaxService()
     {
         $instance = new JsonObjectSerializer();
          //this line proves, that with additional layer json serializer produces valid object
-         $item = $instance->Deserialize('{"TaxService":'.$this->getTaxServiceResponse().'}', true);
-        var_dump($item);
+        $item = $instance->Deserialize('{"TaxService":'.$this->getTaxServiceResponse().'}', true);
         $this->assertTrue($item instanceof IPPTaxService);
         $details = $item->TaxRateDetails[0];
         $this->assertTrue($details instanceof IPPTaxRateDetails);