Skip to content

Migration Fails #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyperiums opened this issue Aug 9, 2019 · 3 comments
Closed

Migration Fails #244

hyperiums opened this issue Aug 9, 2019 · 3 comments

Comments

@hyperiums
Copy link

This method OAuth1ToOAuth2Migration has the redirectUri hard coded which is fine for development but in production it will fail. There is no way to over ride it either. One possible solution is to change scope to be an array of params or add a new param called params so implementation teams can override it easily. Otherwise, the library works great.

@hyperiums
Copy link
Author

Or use the redirect uri from the constructor. That would probably be simpler.

@hyperiums
Copy link
Author

Just realized that $baseURL in this method is hard coded to the prod end point as well which means you can't switch back and forth easily.

@hlu2
Copy link
Contributor

hlu2 commented Aug 12, 2019

@hyperiums I will fix it.

@hlu2 hlu2 closed this as completed in c0871f3 Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants