Controllers should not be forced to send a response for falsey return values

[rmblstrp]

Description

Modified the handling of the the controller's return value so that a the status code 204 is set if the value is undefined after which it will send the result regardless of the type of value.

Related Issue

inversify/InversifyJS#764

Motivation and Context

Controllers should not be forced to send a response if the value they are returning is undefined, NULL, false, or otherwise evaluates as false. Without this change all responses would need to be wrapped to ensure that response.send() is called.

How Has This Been Tested?

it("should work for controller methods who's return value is falsey", (done) => {
    @controller("/user")
    class TestController {
        @httpDelete("/") private async delete(): Promise<void> {
            return;
        }
    }

    server = new InversifyExpressServer(container);
    supertest(server.build())
        .delete("/user")
        .expect(204, "", done);
});

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[remojansen]

👍 thanks a lot for the PR

[rmblstrp]

Thank you for the quick response!

[remojansen]

Hi @rmblstrp I just released [email protected] and it contains your fix 🎉

[rmblstrp]

Thank you sir! Much appreciated! I already updated the package in our codebase. :)