From 19d8882dda9f3317d08211d8d678f12396cae361 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 20 Dec 2023 09:19:27 -0500 Subject: [PATCH 1/5] docs(popover): warn about popover attribute on v5 --- versioned_docs/version-v5/api/popover.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/versioned_docs/version-v5/api/popover.md b/versioned_docs/version-v5/api/popover.md index 856c41273ef..166cab9bce5 100644 --- a/versioned_docs/version-v5/api/popover.md +++ b/versioned_docs/version-v5/api/popover.md @@ -16,6 +16,11 @@ import Slots from '@ionic-internal/component-api/v5/popover/slots.md'; # ion-popover +:::warning +Popover in Ionic v4 may collide with [popover](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover) + feature on newer versions of browsers that can cause Ionic's popovers to not render. We recommend upgrading to the latest version of Ionic to avoid this issue. +::: + A Popover is a dialog that appears on top of the current page. It can be used for anything, but generally it is used for overflow actions that don't fit in the navigation bar. ## Presenting From cd9103b2ac794022656bb69c6dfed975b76b2f80 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 20 Dec 2023 09:19:57 -0500 Subject: [PATCH 2/5] typo --- versioned_docs/version-v5/api/popover.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/versioned_docs/version-v5/api/popover.md b/versioned_docs/version-v5/api/popover.md index 166cab9bce5..03361145bf7 100644 --- a/versioned_docs/version-v5/api/popover.md +++ b/versioned_docs/version-v5/api/popover.md @@ -17,7 +17,7 @@ import Slots from '@ionic-internal/component-api/v5/popover/slots.md'; # ion-popover :::warning -Popover in Ionic v4 may collide with [popover](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover) +Popover in Ionic v5 may collide with [popover](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover) feature on newer versions of browsers that can cause Ionic's popovers to not render. We recommend upgrading to the latest version of Ionic to avoid this issue. ::: From ccac16cac0ee7b53150c1362d5bd85c1cafed5ad Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 20 Dec 2023 09:20:03 -0500 Subject: [PATCH 3/5] typo --- versioned_docs/version-v5/api/popover.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/versioned_docs/version-v5/api/popover.md b/versioned_docs/version-v5/api/popover.md index 03361145bf7..6965a071255 100644 --- a/versioned_docs/version-v5/api/popover.md +++ b/versioned_docs/version-v5/api/popover.md @@ -17,7 +17,7 @@ import Slots from '@ionic-internal/component-api/v5/popover/slots.md'; # ion-popover :::warning -Popover in Ionic v5 may collide with [popover](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover) +Popovers in Ionic v5 may collide with [popover](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover) feature on newer versions of browsers that can cause Ionic's popovers to not render. We recommend upgrading to the latest version of Ionic to avoid this issue. ::: From 51d94d8bab9c9058ddaa6831e28d599a16f3db43 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 20 Dec 2023 09:20:19 -0500 Subject: [PATCH 4/5] typo --- versioned_docs/version-v5/api/popover.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/versioned_docs/version-v5/api/popover.md b/versioned_docs/version-v5/api/popover.md index 6965a071255..d9be869e27d 100644 --- a/versioned_docs/version-v5/api/popover.md +++ b/versioned_docs/version-v5/api/popover.md @@ -17,8 +17,8 @@ import Slots from '@ionic-internal/component-api/v5/popover/slots.md'; # ion-popover :::warning -Popovers in Ionic v5 may collide with [popover](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover) - feature on newer versions of browsers that can cause Ionic's popovers to not render. We recommend upgrading to the latest version of Ionic to avoid this issue. +Popovers in Ionic v5 may collide with the [popover](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover) + feature on newer versions of browsers which can cause Ionic's popovers to not render. We recommend upgrading to the latest version of Ionic to avoid this issue. ::: A Popover is a dialog that appears on top of the current page. It can be used for anything, but generally it is used for overflow actions that don't fit in the navigation bar. From 56bf17a03110e3f9e793da61980342d2abdadd18 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 20 Dec 2023 09:29:15 -0500 Subject: [PATCH 5/5] lint --- versioned_docs/version-v5/api/popover.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/versioned_docs/version-v5/api/popover.md b/versioned_docs/version-v5/api/popover.md index d9be869e27d..f1ce142f03b 100644 --- a/versioned_docs/version-v5/api/popover.md +++ b/versioned_docs/version-v5/api/popover.md @@ -18,7 +18,7 @@ import Slots from '@ionic-internal/component-api/v5/popover/slots.md'; :::warning Popovers in Ionic v5 may collide with the [popover](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover) - feature on newer versions of browsers which can cause Ionic's popovers to not render. We recommend upgrading to the latest version of Ionic to avoid this issue. +feature on newer versions of browsers which can cause Ionic's popovers to not render. We recommend upgrading to the latest version of Ionic to avoid this issue. ::: A Popover is a dialog that appears on top of the current page. It can be used for anything, but generally it is used for overflow actions that don't fit in the navigation bar.