From 00ac44314a4dc387fd4a343e1429614ba7de68f9 Mon Sep 17 00:00:00 2001 From: Ramon Ornelas Date: Thu, 16 Jun 2016 15:36:28 -0300 Subject: [PATCH 1/2] - delete call of events deprecated bug in iOS see #173 --- src/ios/IonicKeyboard.m | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/ios/IonicKeyboard.m b/src/ios/IonicKeyboard.m index d072ca7..e0462e6 100644 --- a/src/ios/IonicKeyboard.m +++ b/src/ios/IonicKeyboard.m @@ -37,8 +37,6 @@ - (void)pluginInitialize { [weakSelf.commandDelegate evalJs:[NSString stringWithFormat:@"cordova.plugins.Keyboard.isVisible = true; cordova.fireWindowEvent('native.keyboardshow', { 'keyboardHeight': %@ }); ", [@(keyboardFrame.size.height) stringValue]]]; - //deprecated - [weakSelf.commandDelegate evalJs:[NSString stringWithFormat:@"cordova.fireWindowEvent('native.showkeyboard', { 'keyboardHeight': %@ }); ", [@(keyboardFrame.size.height) stringValue]]]; }]; _keyboardHideObserver = [nc addObserverForName:UIKeyboardWillHideNotification @@ -46,9 +44,6 @@ - (void)pluginInitialize { queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification* notification) { [weakSelf.commandDelegate evalJs:@"cordova.plugins.Keyboard.isVisible = false; cordova.fireWindowEvent('native.keyboardhide'); "]; - - //deprecated - [weakSelf.commandDelegate evalJs:@"cordova.fireWindowEvent('native.hidekeyboard'); "]; }]; } From a4d91211d8b5353d01f16d4f041fbb14355a1f5c Mon Sep 17 00:00:00 2001 From: Ramon Ornelas Date: Thu, 16 Jun 2016 20:48:25 -0300 Subject: [PATCH 2/2] - delete events deprecated platform android --- www/android/keyboard.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/www/android/keyboard.js b/www/android/keyboard.js index 125a5a2..c80d8c4 100644 --- a/www/android/keyboard.js +++ b/www/android/keyboard.js @@ -41,15 +41,9 @@ channel.onCordovaReady.subscribe(function() { var keyboardHeight = msg.substr(1); cordova.plugins.Keyboard.isVisible = true; cordova.fireWindowEvent('native.keyboardshow', { 'keyboardHeight': + keyboardHeight }); - - //deprecated - cordova.fireWindowEvent('native.showkeyboard', { 'keyboardHeight': + keyboardHeight }); } else if ( action === 'H' ) { cordova.plugins.Keyboard.isVisible = false; cordova.fireWindowEvent('native.keyboardhide'); - - //deprecated - cordova.fireWindowEvent('native.hidekeyboard'); } } });