Merge pull request #164 from TheAngryByrd/fsharp-analyzers-0-34-x

Fsharp analyzers 0 34 x

Author: TheAngryByrd

.config/dotnet-tools.json

@@ -3,7 +3,7 @@
   "isRoot": true,
   "tools": {
     "fsharp-analyzers": {
-      "version": "0.33.1",
+      "version": "0.34.1",
       "commands": [
         "fsharp-analyzers"
       ]

.github/workflows/ci.yml

@@ -38,6 +38,7 @@ jobs:
           dotnet-version: |
             8.x 
             9.x
+            10.x
 
       - name: Build
         run: dotnet fsi build.fsx

.github/workflows/release.yml

@@ -26,6 +26,12 @@ jobs:
 
       - name: Setup .NET
         uses: actions/setup-dotnet@v5
+        with:  
+          global-json-file: 'global.json'
+          dotnet-version: |
+            8.x 
+            9.x
+            10.x
 
       - name: Release
         run: dotnet fsi build.fsx -- -p Release

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.14.10 - 2025-11-11
+
+### Fixed 
+
+* Update FSharp.Analyzers.SDK to `0.34.1`. Checkout the [release notes](https://github.com/ionide/FSharp.Analyzers.SDK/releases/tag/v0.34.1) for details. [#164](https://github.com/ionide/ionide-analyzers/pull/164)
 
 ## 0.14.9 - 2025-10-19
 

Directory.Packages.props

@@ -4,8 +4,8 @@
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
   </PropertyGroup>
   <ItemGroup>
-    <PackageVersion Include="FSharp.Core" Version="[9.0.300]" />
-    <PackageVersion Include="FSharp.Compiler.Service" Version="[43.9.300]" />
+    <PackageVersion Include="FSharp.Core" Version="[10.0.100]" />
+    <PackageVersion Include="FSharp.Compiler.Service" Version="[43.10.100]" />
     <PackageVersion Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" />
     <PackageVersion Include="DotNet.ReproducibleBuilds" Version="1.2.25" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
@@ -14,7 +14,7 @@
     <PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.374" />
   </ItemGroup>
   <ItemGroup Condition="'$(UseLocalAnalyzersSDK)' == 'false'">
-    <PackageVersion Include="FSharp.Analyzers.SDK" Version="[0.33.1]" />
-    <PackageVersion Include="FSharp.Analyzers.SDK.Testing" Version="[0.33.1]" />
+    <PackageVersion Include="FSharp.Analyzers.SDK" Version="[0.34.1]" />
+    <PackageVersion Include="FSharp.Analyzers.SDK.Testing" Version="[0.34.1]" />
   </ItemGroup>
 </Project>

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "9.0.100",
+    "version": "10.0.100",
     "rollForward": "latestMinor"
   }
 }

src/Ionide.Analyzers/Performance/ReturnStructPartialActivePatternAnalyzer.fs

@@ -89,7 +89,6 @@ let rec collectSomeAndNoneFromExprBody (expr: SynExpr) (finalContinuation: Ident
         sequence continuations finalContinuation
 
     | SynExpr.LetOrUse(body = expr)
-    | SynExpr.LetOrUseBang(body = expr)
     | SynExpr.Paren(expr = expr)
     | SynExpr.Typed(expr = expr) -> collectSomeAndNoneFromExprBody expr finalContinuation
     | _ -> finalContinuation []