Fix: fixed test

Author: hmoog

pkg/protocol/engine/consensus/blockgadget/gadget_test.go

@@ -32,8 +32,7 @@ func TestBlockGadget(t *testing.T) {
 	tf.Events.BlockPreConfirmed.Hook(checkOrder(&expectedPreConfirmationOrder, "pre-confirmation"))
 	tf.Events.BlockConfirmed.Hook(checkOrder(&expectedConfirmationOrder, "confirmation"))
 
-	tf.SeatManager.AddRandomAccount("A")
-	tf.SeatManager.AddRandomAccount("B")
+	tf.SeatManager.AddRandomAccounts("A", "B")
 
 	tf.SeatManager.SetOnline("A")
 	tf.SeatManager.SetOnline("B")

pkg/protocol/engine/tipmanager/tests/testframework.go

@@ -67,19 +67,22 @@ func (t *TestFramework) Validator(alias string) iotago.AccountID {
 	return t.manualPOA.AccountID(alias)
 }
 
-func (t *TestFramework) AddValidator(alias string) {
-	t.manualPOA.AddRandomAccount(alias)
+func (t *TestFramework) AddValidators(aliases ...string) {
+	t.manualPOA.AddRandomAccounts(aliases...)
 
-	seat, exists := t.manualPOA.GetSeat(alias)
-	if !exists {
-		panic("seat does not exist")
-	}
+	for _, alias := range aliases {
+		seat, exists := t.manualPOA.GetSeat(alias)
+		if !exists {
+			panic("seat does not exist")
+		}
 
-	t.Instance.AddSeat(seat)
+		t.Instance.AddSeat(seat)
+	}
 }
 
 func (t *TestFramework) AddBlock(alias string) tipmanager.TipMetadata {
 	t.tipMetadataByAlias[alias] = t.Instance.AddBlock(t.Block(alias))
+	t.tipMetadataByAlias[alias].ID().RegisterAlias(alias)
 
 	return t.tipMetadataByAlias[alias]
 }

pkg/protocol/engine/tipmanager/tests/tipmanager_test.go

@@ -62,6 +62,8 @@ func Test_Orphanage(t *testing.T) {
 func Test_ValidationTips(t *testing.T) {
 	tf := NewTestFramework(t)
 
+	tf.AddValidators("validatorA", "validatorB")
+
 	{
 		tf.CreateBasicBlock("1", map[iotago.ParentsType][]string{
 			iotago.StrongParentType: {"Genesis"},
@@ -78,8 +80,6 @@ func Test_ValidationTips(t *testing.T) {
 
 	// Add validation tip for validatorA.
 	{
-		tf.AddValidator("validatorA")
-
 		tf.CreateValidationBlock("3", map[iotago.ParentsType][]string{
 			iotago.StrongParentType: {"2"},
 		}, func(blockBuilder *builder.ValidationBlockBuilder) {
@@ -94,8 +94,6 @@ func Test_ValidationTips(t *testing.T) {
 
 	// Add validation tip for validatorB.
 	{
-		tf.AddValidator("validatorB")
-
 		tf.CreateValidationBlock("4", map[iotago.ParentsType][]string{
 			iotago.StrongParentType: {"1"},
 		}, func(blockBuilder *builder.ValidationBlockBuilder) {

pkg/protocol/sybilprotection/seatmanager/mock/mockseatmanager.go

@@ -58,26 +58,32 @@ func NewManualPOAProvider() module.Provider[*engine.Engine, seatmanager.SeatMana
 	})
 }
 
-func (m *ManualPOA) AddRandomAccount(alias string) iotago.AccountID {
-	id := iotago.AccountID(tpkg.Rand32ByteArray())
-	id.RegisterAlias(alias)
-	if err := m.accounts.Set(id, &account.Pool{ // We don't care about pools with PoA, but need to set something to avoid division by zero errors.
-		PoolStake:      1,
-		ValidatorStake: 1,
-		FixedCost:      1,
-	}); err != nil {
-		panic(err)
-	}
+func (m *ManualPOA) AddRandomAccounts(aliases ...string) (accountIDs []iotago.AccountID) {
+	accountIDs = make([]iotago.AccountID, len(aliases))
+
+	for i, alias := range aliases {
+		id := iotago.AccountID(tpkg.Rand32ByteArray())
+		id.RegisterAlias(alias)
+		if err := m.accounts.Set(id, &account.Pool{ // We don't care about pools with PoA, but need to set something to avoid division by zero errors.
+			PoolStake:      1,
+			ValidatorStake: 1,
+			FixedCost:      1,
+		}); err != nil {
+			panic(err)
+		}
 
-	m.aliases.Set(alias, id)
+		m.aliases.Set(alias, id)
+
+		accountIDs[i] = id
+	}
 
 	m.committee = m.accounts.SeatedAccounts(m.accounts.IDs()...)
 
 	if err := m.committeeStore.Store(0, m.accounts); err != nil {
 		panic(err)
 	}
 
-	return id
+	return accountIDs
 }
 
 func (m *ManualPOA) AddAccount(id iotago.AccountID, alias string) iotago.AccountID {