Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

Commit cd4a827

Browse files
committed
Remove "changed" return value from updateIsFinalizationDelayed because it is not needed
1 parent 372663a commit cd4a827

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

pkg/protocol/engine/syncmanager/trivialsyncmanager/syncmanager.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -260,23 +260,16 @@ func (s *SyncManager) IsNodeSynced() bool {
260260
return s.isSynced
261261
}
262262

263-
func (s *SyncManager) updateIsFinalizationDelayed(latestFinalizedSlot iotago.SlotIndex, latestCommitmentSlot iotago.SlotIndex) (changed bool) {
263+
func (s *SyncManager) updateIsFinalizationDelayed(latestFinalizedSlot iotago.SlotIndex, latestCommitmentSlot iotago.SlotIndex) {
264264
s.isFinalizationDelayedLock.Lock()
265265
defer s.isFinalizationDelayedLock.Unlock()
266266

267267
if latestCommitmentSlot < latestFinalizedSlot {
268268
// This should never happen, but if it does, we don't want to panic.
269-
return false
269+
return
270270
}
271271

272-
isFinalizationDelayed := latestCommitmentSlot-latestFinalizedSlot > s.engine.CommittedAPI().ProtocolParameters().MaxCommittableAge()
273-
if s.isFinalizationDelayed != isFinalizationDelayed {
274-
s.isFinalizationDelayed = isFinalizationDelayed
275-
276-
return true
277-
}
278-
279-
return false
272+
s.isFinalizationDelayed = latestCommitmentSlot-latestFinalizedSlot > s.engine.CommittedAPI().ProtocolParameters().MaxCommittableAge()
280273
}
281274

282275
func (s *SyncManager) IsFinalizationDelayed() bool {

0 commit comments

Comments
 (0)