feat: hook implicit account logic step3 (#7906)

* refactor(2.0): Dynamic password

* refactor(2.0): Remove Profile Manager (wip)

* clean up and fix

* clean up

* clean up more code

* feat: add account to routes

* feat: add to analytics featureflag

* feat: add account view and multistep

* style: refinements

* feat: rename  files and add locale

* feat: prepare UI step 1

* feat: add locales

* fix: update naming

* feat: update naming and improve code

* fix: move comment

* fix import

* feat: hook logic

* clean up

* adapt and remove for profile-manager related code

* clean up more code

* fmt

* fix: remove accountImplicit route and add to wallet tab

* fix: improve naming

* Update packages/desktop/views/dashboard/wallet/Wallet.svelte

* Update packages/desktop/views/dashboard/wallet/Wallet.svelte

* more cleanup

* fix: add router

* minor fixes

* more cleanup

* ix: add missing dots

* fix: colors

* fix: remove unnecessary function

* fix: rename files

* fix: move if/else and key block

* fix: reset after finish

* small tweaks

* fix: undo changes

* feat: use implicitAccountCreationAddress

* fix: rename and remove onmount

* more cleanup

* format

* update

* clean up

* feat: hook logic, first steps

* fix: add todo

* https://api.testnet.shimmer.network

* revert Wallet.svelte

* clean up

* feat: hook logic in implicit account creation step 3

* clean up

* clean up

* feat: update logic to go next route

* fix: update logic

* feat: remove getNftByIdFromAllAccountNfts debris

* feat: hook implicit account logic step3 done

* fix: problem with the merge

* fix: avoid reactive error

* fix: remove logic duplicated

---------

Co-authored-by: marc2332 <[email protected]>
Co-authored-by: evavirseda <[email protected]>
Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>

Author: 4 people

packages/desktop/views/dashboard/wallet/Wallet.svelte

@@ -2,7 +2,7 @@
     import { selectedWallet } from '@core/wallet'
     import { ImplicitAccountCreationView, WalletView } from './views'
 
-    $: hasAccount = $selectedWallet.accountOutputs.length !== 0
+    $: hasAccount = $selectedWallet?.accountOutputs?.length !== 0
 </script>
 
 {#if $selectedWallet}

packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/AccountCreationView.svelte

@@ -1,19 +1,31 @@
 <script lang="ts">
     import { Button, FontWeight, PasswordInput, Text, TextType } from 'shared/components'
     import { localize } from '@core/i18n'
-    import { showAppNotification } from '@auxiliary/notification'
+    import { selectedWallet } from '@core/wallet'
+    import { activeProfile, unlockStronghold } from '@core/profile'
+    import { get } from 'svelte/store'
 
     let error = ''
+    let isBusy = false
     let strongholdPassword = ''
-    $: strongholdPassword, (error = '')
 
-    function unlockWalletAndCreateAccount(): void {
-        // TODO: add logic to active account
-        showAppNotification({
-            type: 'error',
-            alert: true,
-            message: localize('error.global.generic'),
-        })
+    async function unlockWalletAndCreateAccount(): Promise<void> {
+        isBusy = true
+        error = ''
+        try {
+            if (!strongholdPassword || $selectedWallet?.implicitAccountOutputs.length === 0) return
+            // TODO(2.0): patch because it comes unlocked by default
+            const { isStrongholdLocked } = get(activeProfile)
+            isStrongholdLocked.set(true)
+
+            await unlockStronghold(strongholdPassword)
+            const outputId = $selectedWallet?.implicitAccountOutputs[0].outputId
+            await $selectedWallet?.implicitAccountTransition(outputId)
+        } catch (err) {
+            console.error('err', err)
+            error = localize(err?.message ?? err)
+            isBusy = false
+        }
     }
 </script>
 
@@ -29,14 +41,16 @@
             >{localize('views.implicit-account-creation.steps.step3.view.title')}</Text
         >
         <PasswordInput
-            {error}
+            bind:error
             bind:value={strongholdPassword}
             autofocus
             submitHandler={unlockWalletAndCreateAccount}
             placeholder={localize('views.implicit-account-creation.steps.step3.view.placeholder')}
         />
     </div>
-    <Button onClick={unlockWalletAndCreateAccount}
-        >{localize('views.implicit-account-creation.steps.step2.view.action')}</Button
+    <Button
+        onClick={unlockWalletAndCreateAccount}
+        disabled={!strongholdPassword || strongholdPassword.length === 0 || isBusy}
+        {isBusy}>{localize('views.implicit-account-creation.steps.step2.view.action')}</Button
     >
 </step-content>

packages/shared/lib/core/secret-manager/stores/secret-manager.store.ts

@@ -1,5 +1,5 @@
 import { api } from '@core/api'
-import { activeProfile } from '@core/profile/stores/active-profile.store'
+import { activeProfile } from '@core/profile/stores'
 import { SecretManager, SecretManagerType } from '@iota/sdk'
 import { writable } from 'svelte/store'
 

packages/shared/lib/core/wallet/actions/events-handlers/handleNewOutputEvent.ts

@@ -16,7 +16,6 @@ import {
     addPersistedAsset,
     generateActivities,
     getOrRequestAssetFromPersistedAssets,
-    allWalletActivities,
     syncBalance,
     validateWalletApiEvent,
     getBech32AddressFromAddressTypes,
@@ -63,15 +62,23 @@ export async function handleNewOutputEventInternal(walletId: string, payload: Ne
         return
     }
 
+    const isAccountOutput = output.type === OutputType.Account
+
+    if (isAccountOutput) {
+        const accounts = await wallet.accounts()
+        const depositAddress = await getDepositAddress(wallet)
+        updateSelectedWallet({
+            accountOutputs: accounts,
+            depositAddress,
+        })
+        return
+    }
+
     const address = getBech32AddressFromAddressTypes(outputData.address)
-    const isNewAliasOutput =
-        output.type === OutputType.Account &&
-        !get(allWalletActivities)[walletId].find((_activity) => _activity.id === outputData.outputId)
-    const isNftOutput = output.type === OutputType.Nft
 
-    const isAccountOutput = output.type === OutputType.Account
+    const isNftOutput = output.type === OutputType.Nft
 
-    if ((wallet?.depositAddress === address && !outputData?.remainder) || isNewAliasOutput) {
+    if (wallet?.depositAddress === address && !outputData?.remainder) {
         await syncBalance(wallet.id)
         const walletOutputs = await wallet.outputs()
         updateActiveWallet(wallet.id, { walletOutputs })
@@ -98,13 +105,4 @@ export async function handleNewOutputEventInternal(walletId: string, payload: Ne
 
         checkAndRemoveProfilePicture()
     }
-
-    if (isAccountOutput) {
-        const accounts = await wallet.accounts()
-        const depositAddress = await getDepositAddress(wallet)
-        updateSelectedWallet({
-            accountOutputs: accounts,
-            depositAddress,
-        })
-    }
 }

packages/shared/lib/core/wallet/utils/getDepositAddress.ts

@@ -1,11 +1,14 @@
-import { AccountOutput } from '@iota/sdk'
+import { AccountAddress, AccountOutput } from '@iota/sdk/out/types'
 import { IWallet } from '../../profile/interfaces'
+import { getBech32AddressFromAddressTypes } from './getBech32AddressFromAddressTypes'
 
 // TODO(2.0): Update the implementation to handle multiple accounts and use the selected account's address.
 export async function getDepositAddress(wallet: IWallet): Promise<string> {
     const accounts = await wallet?.accounts()
     if (accounts?.length) {
-        return (accounts[0]?.output as AccountOutput).accountId ?? ''
+        const accountId = (accounts[0]?.output as AccountOutput).accountId
+        const accountAddress = getBech32AddressFromAddressTypes(new AccountAddress(accountId))
+        return accountAddress ?? ''
     } else {
         return ''
     }