feat: update deposit address to selected created explicit account (#7907)

* feat: add account to routes

* feat: add to analytics featureflag

* fix: update naming

* feat: update wallet state to accomodate accounts

* feat: update events to accomodate accounts WIP

* feat: improve validate wallet api event

* feat: improve imports

* fix merge

* feat: remove duplicate implicitAccountCreationRouter

* perf: update todo comment for getDepositAddress function

* feat: update dashboard to route to dashboard or implicit flow based on wallet status

* feat: update event to walletEvent

* feat: update subscribeToWalletApiEventsForActiveProfile with new WalletEvent

* fix: move onDestroy to the last view of implicit account creation

* perf: hasAccount reactive

* perf: rename accountsOutput and implicitAccountsOutput

* fix: undo unsubscribeFromWalletApiEvents place

* perf: add implicit account logic to handleNewOutputEventInternal

* feat: imporve isImplicitAccountOutput logic

* feat: uopdate depositAddress to selected explicit acocunt

* fix: get depositAddres

* fix function and remove arguments

* fix: update comment

* fix: update depositAddress

* fix: remove comment and constant

* fix: remove duplicated code

* fix: bring back arg

---------

Co-authored-by: cpl121 <[email protected]>
Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>

Author: 3 people

packages/shared/lib/core/wallet/actions/events-handlers/handleNewOutputEvent.ts

@@ -8,7 +8,6 @@ import {
     AddressType,
     AddressUnlockCondition,
 } from '@iota/sdk/out/types'
-
 import { addNftsToDownloadQueue, addOrUpdateNftInAllAccountNfts, buildNftFromNftOutput } from '@core/nfts'
 import { checkAndRemoveProfilePicture } from '@core/profile/actions'
 import {
@@ -26,6 +25,7 @@ import {
     addActivitiesToWalletActivitiesInAllWalletActivities,
     WalletApiEventHandler,
     updateSelectedWallet,
+    getDepositAddress,
 } from '@core/wallet'
 import { get } from 'svelte/store'
 import { activeWallets, updateActiveWallet } from '@core/profile'
@@ -103,8 +103,10 @@ export async function handleNewOutputEventInternal(walletId: string, payload: Ne
 
     if (isAccountOutput) {
         const accounts = await wallet.accounts()
+        const depositAddress = await getDepositAddress(wallet)
         updateSelectedWallet({
             accountOutputs: accounts,
+            depositAddress,
         })
     }
 }

packages/shared/lib/core/wallet/utils/getDepositAddress.ts

@@ -1,6 +1,12 @@
-import { IWallet } from '@core/profile/interfaces'
+import { AccountOutput } from '@iota/sdk'
+import { IWallet } from '../../profile/interfaces'
 
-// TODO(2.0): the implementation is incorrect, the deposit address should be the address of the selected block issuer account output , not the ed25519 address
-export function getDepositAddress(wallet: IWallet): Promise<string> {
-    return wallet.address()
+// TODO(2.0): Update the implementation to handle multiple accounts and use the selected account's address.
+export async function getDepositAddress(wallet: IWallet): Promise<string> {
+    const accounts = await wallet?.accounts()
+    if (accounts?.length) {
+        return (accounts[0]?.output as AccountOutput).accountId ?? ''
+    } else {
+        return ''
+    }
 }