From a758ef10d3b2ba5df2901287983bbda656d32065 Mon Sep 17 00:00:00 2001 From: cpl121 <100352899+cpl121@users.noreply.github.com> Date: Tue, 19 Dec 2023 09:58:04 +0100 Subject: [PATCH] refactor: Fix Login and onboarding improvements (#7779) * refactor: login WIP * fix: selected wallet id * mmm, some improvements and fixes * fixes and improvements * fixes and clean up --------- Co-authored-by: marc2332 --- .../desktop/components/AccountSummary.svelte | 4 +- .../desktop/components/AccountSwitcher.svelte | 4 +- .../modals/WalletActionsMenu.svelte | 2 +- .../components/popups/AddNodePopup.svelte | 4 +- .../components/popups/AddProposalPopup.svelte | 18 +++--- .../popups/CreateWalletPopup.svelte | 2 +- ...tPopup.svelte => ManageWalletPopup.svelte} | 28 +++++----- .../desktop/components/popups/Popup.svelte | 6 +- .../popups/RemoveProposalPopup.svelte | 4 +- packages/desktop/electron/preload.js | 50 +++++++++++------ .../login/views/SelectProfileView.svelte | 1 - .../views/FinishOnboardingView.svelte | 1 - .../views/ChooseCreateProfileFlowView.svelte | 1 - .../views/shared/EncryptMnemonicView.svelte | 5 +- packages/shared/components/ColorPicker.svelte | 20 +++---- packages/shared/components/SubjectBox.svelte | 6 +- .../ToggleHiddenAccountMenuItem.svelte | 7 +-- .../deep-link/handlers/handleDeepLink.ts | 4 +- .../auxiliary/popup/enums/popup-id.enum.ts | 2 +- .../lib/contexts/governance/actions/index.ts | 2 +- .../initializeParticipationOverviews.ts | 10 ++-- ...unts.ts => registerProposalsForWallets.ts} | 6 +- .../actions/registerProposalsFromNodes.ts | 4 +- .../actions/completeOnboardingProcess.ts | 31 +++++------ ...liseProfileManagerFromOnboardingProfile.ts | 2 - .../actions/verifyAndStoreMnemonic.ts | 1 + ...vertOnboardingProfileToPersistedProfile.ts | 4 +- .../helpers/getSortedRenamedBoundAccounts.ts | 2 +- .../stores/onboarding-profile.store.ts | 8 +-- .../stores/onboarding-secret-manager.store.ts | 55 +++++++++++++------ .../lib/core/api/interfaces/api.interface.ts | 3 +- .../constants/official-node-urls.constant.ts | 2 +- .../core/network/stores/node-info.store.ts | 4 +- .../utils/getNetworkIdFromNetworkName.ts | 1 + .../shared/lib/core/nfts/actions/index.ts | 2 +- .../nfts/actions/loadNftsForActiveProfile.ts | 30 +++++----- ...fts.ts => setWalletNftsInAllWalletNfts.ts} | 4 +- ...ress.ts => findActiveWalletWithAddress.ts} | 2 +- .../profile/actions/active-accounts/index.ts | 4 +- ....ts => updateActiveWalletPersistedData.ts} | 3 +- .../checkAndUpdateActiveProfileNetwork.ts | 3 +- .../actions/active-profile/loadWallets.ts | 2 +- .../profile/actions/active-profile/login.ts | 45 ++++++++------- .../active-profile/saveActiveProfile.ts | 2 +- .../profile/actions/clearProfileFromMemory.ts | 4 ++ .../lib/core/profile/actions/createWallet.ts | 39 ++++++++----- .../lib/core/profile/actions/deleteWallet.ts | 2 +- .../lib/core/profile/actions/getWallet.ts | 2 +- .../lib/core/profile/actions/getWallets.ts | 8 +-- .../checkAndMigrateChrysalisProfiles.ts | 12 ++-- ...fault-persisted-profile-object.constant.ts | 2 +- .../interfaces/login-options.interface.ts | 2 +- .../interfaces/persisted-profile.interface.ts | 6 +- .../profile/stores/active-profile.store.ts | 16 +++--- .../profile/stores/active-wallets.store.ts | 2 +- .../utils/getSecretManagerFromProfileType.ts | 2 +- .../secret-manager/actions/storeMnemonic.ts | 5 +- .../generateAndStoreActivitiesForAccount.ts | 32 ----------- .../generateAndStoreActivitiesForWallet.ts | 31 +++++++++++ .../core/wallet/actions/activities/index.ts | 8 +-- ...Accounts.ts => loadAssetsForAllWallets.ts} | 8 +-- ...count.ts => preprocessOutputsForWallet.ts} | 18 +++--- ....ts => preprocessTransactionsForWallet.ts} | 6 +- .../setAsyncStatusOfAccountActivities.ts | 4 +- .../core/wallet/actions/buildWalletState.ts | 16 +++--- .../buildWalletStateAndPersistedData.ts | 17 +++--- .../core/wallet/actions/createNewWallet.ts | 21 ++++--- .../handleTransactionInclusionEvent.ts | 6 +- ...enerateAndStoreActivitiesForAllAccounts.ts | 15 ----- ...generateAndStoreActivitiesForAllWallets.ts | 15 +++++ .../wallet/actions/getAddressesWithOutputs.ts | 3 + .../lib/core/wallet/actions/getClient.ts | 9 ++- .../lib/core/wallet/actions/getNodeInfo.ts | 3 +- .../shared/lib/core/wallet/actions/index.ts | 4 +- .../lib/core/wallet/actions/loadWallet.ts | 5 +- ...=> refreshWalletAssetsForActiveProfile.ts} | 12 ++-- .../core/wallet/actions/setClientOptions.ts | 1 + .../wallet/actions/setStrongholdPassword.ts | 1 - .../lib/core/wallet/enums/subject.enum.ts | 2 +- .../interfaces/wallet-subject.interface.ts | 6 +- .../selected-wallet-activities.store.ts | 4 +- .../lib/core/wallet/types/subject.type.ts | 4 +- .../helper/getSubjectFromActivity.ts | 4 +- .../getIrc30MetadataFromFoundryOutput.ts | 4 +- .../wallet/utils/getSubjectFromAddress.ts | 6 +- .../core/wallet/utils/isSubjectInternal.ts | 2 +- .../outputs/preprocessOutgoingTransaction.ts | 4 +- packages/shared/locales/en.json | 5 +- 88 files changed, 417 insertions(+), 362 deletions(-) rename packages/desktop/components/popups/{ManageAccountPopup.svelte => ManageWalletPopup.svelte} (69%) rename packages/shared/lib/contexts/governance/actions/{registerProposalsForAccounts.ts => registerProposalsForWallets.ts} (60%) rename packages/shared/lib/core/nfts/actions/{setAccountNftsInAllAccountNfts.ts => setWalletNftsInAllWalletNfts.ts} (51%) rename packages/shared/lib/core/profile/actions/active-accounts/{findActiveAccountWithAddress.ts => findActiveWalletWithAddress.ts} (85%) rename packages/shared/lib/core/profile/actions/active-accounts/{updateActiveAccountPersistedData.ts => updateActiveWalletPersistedData.ts} (83%) delete mode 100644 packages/shared/lib/core/wallet/actions/activities/generateAndStoreActivitiesForAccount.ts create mode 100644 packages/shared/lib/core/wallet/actions/activities/generateAndStoreActivitiesForWallet.ts rename packages/shared/lib/core/wallet/actions/activities/{loadAssetsForAllAccounts.ts => loadAssetsForAllWallets.ts} (73%) rename packages/shared/lib/core/wallet/actions/activities/{preprocessOutputsForAccount.ts => preprocessOutputsForWallet.ts} (69%) rename packages/shared/lib/core/wallet/actions/activities/{preprocessTransactionsForAccount.ts => preprocessTransactionsForWallet.ts} (73%) delete mode 100644 packages/shared/lib/core/wallet/actions/generateAndStoreActivitiesForAllAccounts.ts create mode 100644 packages/shared/lib/core/wallet/actions/generateAndStoreActivitiesForAllWallets.ts rename packages/shared/lib/core/wallet/actions/{refreshAccountAssetsForActiveProfile.ts => refreshWalletAssetsForActiveProfile.ts} (82%) diff --git a/packages/desktop/components/AccountSummary.svelte b/packages/desktop/components/AccountSummary.svelte index dabca0bd6d5..8ff8e230589 100644 --- a/packages/desktop/components/AccountSummary.svelte +++ b/packages/desktop/components/AccountSummary.svelte @@ -4,11 +4,11 @@ import { TextType } from '@ui/enums' import { localize } from '@core/i18n' - import { nodeInfo } from '@core/network' + import { nodeInfoNetworkName } from '@core/network' import { selectedWalletAssets } from '@core/wallet' import { activeProfile } from '@core/profile' - $: fomattedNetworkName = $nodeInfo?.protocol.networkName + $: fomattedNetworkName = $nodeInfoNetworkName .split(' ') .map((word) => word[0].toUpperCase() + word.substring(1)) .join(' ') diff --git a/packages/desktop/components/AccountSwitcher.svelte b/packages/desktop/components/AccountSwitcher.svelte index 3a7f999e137..0c28b0a6616 100644 --- a/packages/desktop/components/AccountSwitcher.svelte +++ b/packages/desktop/components/AccountSwitcher.svelte @@ -1,5 +1,5 @@ -{#if subject?.type === SubjectType.Account} +{#if subject?.type === SubjectType.Wallet} - + {:else if subject?.type === SubjectType.Address} diff --git a/packages/shared/components/menu-items/ToggleHiddenAccountMenuItem.svelte b/packages/shared/components/menu-items/ToggleHiddenAccountMenuItem.svelte index 029dfc8f95d..d80cffac866 100644 --- a/packages/shared/components/menu-items/ToggleHiddenAccountMenuItem.svelte +++ b/packages/shared/components/menu-items/ToggleHiddenAccountMenuItem.svelte @@ -1,8 +1,7 @@