feat: Improve ExpirationTimePicker component (#7782)

evavirseda · brancoder · begonaalvarezd · web-flow · commit ca652cdc8155 · 2024-01-25T17:50:39.000+01:00
* refactor: improve expirationTimePicker componente

* fix:revert changes to expiration time picker

* fix: persist expiration time picker value when toggling gift storage deposit

---------

Co-authored-by: Branko Bosnic &lt;brankobosnic1@gmail.com&gt;
Co-authored-by: Begoña Álvarez de la Cruz &lt;balvarez@boxfish.studio&gt;
diff --git a/packages/desktop/components/popups/send/SendConfirmationPopup.svelte b/packages/desktop/components/popups/send/SendConfirmationPopup.svelte
@@ -60,7 +60,6 @@
     let visibleSurplus: number | undefined = undefined
 
     let isPreparingOutput = false
-
     $: expirationTimePicker?.setNull(giftStorageDeposit)
 
     $: isBaseTokenTransfer =
diff --git a/packages/shared/components/ExpirationTimePicker.svelte b/packages/shared/components/ExpirationTimePicker.svelte
@@ -14,8 +14,11 @@
         if (bool && value) {
             storedValue = value
             value = null
+            previouslySelectedPeriod = selectedTimePeriod
+            selectedTimePeriod = TimePeriod.None
         } else {
             value = storedValue ?? value
+            selectedTimePeriod = previouslySelectedPeriod
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,11 @@`
`14`	`14`	`if (bool && value) {`
`15`	`15`	`storedValue = value`
`16`	`16`	`value = null`
	`17`	`+ previouslySelectedPeriod = selectedTimePeriod`
	`18`	`+ selectedTimePeriod = TimePeriod.None`
`17`	`19`	`} else {`
`18`	`20`	`value = storedValue ?? value`
	`21`	`+ selectedTimePeriod = previouslySelectedPeriod`
`19`	`22`	`}`
`20`	`23`	`}`
`21`	`24`