Skip to content

Commit d982311

Browse files
authored
chore: Update to @electron/notarize for new notarytool (#7678)
1 parent b3f64f7 commit d982311

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

packages/desktop/electron-builder-config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const prodConfig = () => ({
1212
afterSign: async () => {
1313
// eslint-disable-next-line no-useless-catch
1414
try {
15-
await notarize(APP_ID, getAppName())
15+
await notarize(getAppName())
1616
} catch (err) {
1717
// This catch is necessary or the promise rejection is swallowed
1818
throw err

packages/desktop/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"url": "^0.11.0"
4343
},
4444
"devDependencies": {
45+
"@electron/notarize": "^2.1.0",
4546
"@sentry/webpack-plugin": "^1.18.5",
4647
"@tsconfig/svelte": "^4.0.1",
4748
"@types/webpack": "^5.28.1",
@@ -50,7 +51,6 @@
5051
"css-loader": "^6.7.3",
5152
"electron": "22.3.27",
5253
"electron-builder": "^24.0.0",
53-
"electron-notarize": "^1.0.0",
5454
"esbuild-loader": "^4.0.2",
5555
"lodash.merge": "^4.6.2",
5656
"mini-css-extract-plugin": "^2.7.6",

packages/desktop/scripts/notarize.macos.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
const { notarize } = require('electron-notarize')
1+
const { notarize } = require('@electron/notarize')
22
const path = require('path')
33

44
/**
55
*
66
* @param {string} appName
77
* @returns void
88
*/
9-
module.exports = async (appBundleId, appName) => {
9+
module.exports = async (appName) => {
1010
if (process.platform !== 'darwin' || process.env.MACOS_SKIP_NOTARIZATION) {
1111
return true
1212
}
@@ -23,10 +23,9 @@ module.exports = async (appBundleId, appName) => {
2323
}
2424

2525
await notarize({
26-
appBundleId: appBundleId,
2726
appPath: path.resolve(__dirname, `../out/mac/${appName}.app`),
2827
appleId: APPLE_ID,
2928
appleIdPassword: APPLE_ID_PASSWORD,
30-
ascProvider: 'UG77RJKZHH',
29+
teamId: 'UG77RJKZHH',
3130
})
3231
}

yarn.lock

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,15 @@
458458
debug "^4.1.1"
459459
fs-extra "^9.0.1"
460460

461+
"@electron/notarize@^2.1.0":
462+
version "2.1.0"
463+
resolved "https://registry.yarnpkg.com/@electron/notarize/-/notarize-2.1.0.tgz#76aaec10c8687225e8d0a427cc9df67611c46ff3"
464+
integrity sha512-Q02xem1D0sg4v437xHgmBLxI2iz/fc0D4K7fiVWHa/AnW8o7D751xyKNXgziA6HrTOme9ul1JfWN5ark8WH1xA==
465+
dependencies:
466+
debug "^4.1.1"
467+
fs-extra "^9.0.1"
468+
promise-retry "^2.0.1"
469+
461470
"@electron/osx-sign@^1.0.4":
462471
version "1.0.4"
463472
resolved "https://registry.yarnpkg.com/@electron/osx-sign/-/osx-sign-1.0.4.tgz#8e91442846471636ca0469426a82b253b9170151"
@@ -3489,14 +3498,6 @@ electron-log@^4.3.1:
34893498
resolved "https://registry.yarnpkg.com/electron-log/-/electron-log-4.4.8.tgz#fcb9f714dbcaefb6ac7984c4683912c74730248a"
34903499
integrity sha512-QQ4GvrXO+HkgqqEOYbi+DHL7hj5JM+nHi/j+qrN9zeeXVKy8ZABgbu4CnG+BBqDZ2+tbeq9tUC4DZfIWFU5AZA==
34913500

3492-
electron-notarize@^1.0.0:
3493-
version "1.2.2"
3494-
resolved "https://registry.yarnpkg.com/electron-notarize/-/electron-notarize-1.2.2.tgz#ebf2b258e8e08c1c9f8ff61dc53d5b16b439daf4"
3495-
integrity sha512-ZStVWYcWI7g87/PgjPJSIIhwQXOaw4/XeXU+pWqMMktSLHaGMLHdyPPN7Cmao7+Cr7fYufA16npdtMndYciHNw==
3496-
dependencies:
3497-
debug "^4.1.1"
3498-
fs-extra "^9.0.1"
3499-
35003501
35013502
version "24.4.0"
35023503
resolved "https://registry.yarnpkg.com/electron-publish/-/electron-publish-24.4.0.tgz#a58f49ecd727620f65372881788ebb1a9b853284"

0 commit comments

Comments
 (0)