Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Improve send confirmation disabled button #7770

Closed
begonaalvarezd opened this issue Dec 8, 2023 · 0 comments · Fixed by #7771
Closed

[Task]: Improve send confirmation disabled button #7770

begonaalvarezd opened this issue Dec 8, 2023 · 0 comments · Fixed by #7771
Assignees
@begonaalvarezd
Labels
type:enhancement Enhancement to existing feature
Milestone
E00.M1 - Stardust...

Comments

@begonaalvarezd
Copy link
Member

Task description

seems we missed a disabled flag for the Send button on the SendConfirmationPopup side
there is an isTransferring and there is disabled on SendToken/NftPopup, but in SendConfirmation we have to prepare again in some cases
we should add one there too
@begonaalvarezd begonaalvarezd added the type:enhancement Enhancement to existing feature label Dec 8, 2023
@begonaalvarezd begonaalvarezd moved this from 📋 Backlog to 🔖 Todo in Firefly - Task Management Dec 8, 2023
@begonaalvarezd begonaalvarezd moved this from 🔖 Todo to 🏗 In Progress in Firefly - Task Management Dec 8, 2023
@begonaalvarezd begonaalvarezd mentioned this issue Dec 8, 2023
Merged
10 tasks
@begonaalvarezd begonaalvarezd linked a pull request Dec 8, 2023 that will close this issue
enhancement: dont allow sending while preparing the output for the transaction #7771
Merged
10 tasks
@begonaalvarezd begonaalvarezd moved this from 🏗 In Progress to 👀 Needs Review in Firefly - Task Management Dec 8, 2023
@github-project-automation github-project-automation bot moved this from 👀 Needs Review to 🎉 Done in Firefly - Task Management Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@begonaalvarezd begonaalvarezd

Labels
type:enhancement Enhancement to existing feature
Projects
Firefly - Task Management
Status: 🎉 Done
Milestone
E00.M1 - Stardust Backlog
Development

Successfully merging a pull request may close this issue.

enhancement: dont allow sending while preparing the output for the transaction iotaledger/firefly
2 participants
@begonaalvarezd @msarcev