Add comment

Author: jonastheis

pkg/protocol/engine/consensus/blockgadget/thresholdblockgadget/witness_weight.go

@@ -34,6 +34,9 @@ func (g *Gadget) TrackWitnessWeight(votingBlock *blocks.Block) {
 			propagateFurther = true
 		}
 
+		// Skip propagation of pre-confirmation if the block is not in the same epoch as the votingBlock.
+		// This might delay the (pre-)confirmation of blocks at the end of the epoch but make sure that (pre-)confirmation
+		// is safe in case where the minority of voters got different seats for the next epoch.
 		blockEpoch := block.ProtocolBlock().API.TimeProvider().EpochFromSlot(block.ID().Slot())
 		if !block.IsPreConfirmed() && votingBlockEpoch == blockEpoch && (shouldPreConfirm || anyChildInSet(block, toPreConfirmByID)) {
 			toPreConfirm = append([]*blocks.Block{block}, toPreConfirm...)

pkg/tests/confirmation_state_test.go

@@ -5,7 +5,6 @@ import (
 	"testing"
 
 	"github.com/iotaledger/hive.go/lo"
-	"github.com/iotaledger/hive.go/log"
 	"github.com/iotaledger/hive.go/runtime/options"
 	"github.com/iotaledger/iota-core/pkg/protocol"
 	"github.com/iotaledger/iota-core/pkg/protocol/engine/notarization/slotnotarization"
@@ -276,8 +275,6 @@ func TestConfirmationOverEpochBoundary(t *testing.T) {
 
 	ts.Run(true)
 
-	ts.Node("node0").Protocol.SetLogLevel(log.LevelTrace)
-
 	// Issue blocks up until 1 slot more than the epoch.
 	{
 		ts.IssueBlocksAtSlots("", []iotago.SlotIndex{1, 2, 3, 4, 5, 6, 7, 8, 9}, 4, "Genesis", ts.Nodes(), true, false)