Check errors and renaming

Author: jkrvivian

pkg/tests/combined_account_transition_test.go

@@ -56,15 +56,15 @@ func Test_AccountStateTransition(t *testing.T) {
 	// create the account2, from implicit to full account from TX1:1 with wallet "second"
 	// generated (block2, TX3), (block3, TX4)
 	ts.AddWallet("second", node1, iotago.EmptyAccountID)
-	implicitAccID := createImplicitToFullAccount(ts)
+	account2ID := createImplicitToFullAccount(ts)
 
 	// send funds to account2, with TX1:2
 	// generated (block4, TX5)
-	sendfunds(ts)
+	sendFunds(ts)
 
 	// allot 1000 mana to account2 with TX1:3
 	// generated (block5, TX6)
-	allotManaTo(ts, implicitAccID)
+	allotManaTo(ts, account2ID)
 
 	// create native token from "TX5:0" and account2 (TX4:0)
 	// generated (block6, TX7)
@@ -200,7 +200,7 @@ func createImplicitToFullAccount(ts *testsuite.TestSuite) iotago.AccountID {
 	return implicitAccountID
 }
 
-func sendfunds(ts *testsuite.TestSuite) {
+func sendFunds(ts *testsuite.TestSuite) {
 	node1 := ts.Node("node1")
 	node2 := ts.Node("node2")
 	wallet := ts.DefaultWallet()

pkg/testsuite/mock/wallet_transactions.go

@@ -677,7 +677,7 @@ func (w *Wallet) CreateNativeTokenFromInput(transactionName string, inputName st
 	accTransitionOutput := builder.NewAccountOutputBuilderFromPrevious(accountOutput.Output().(*iotago.AccountOutput)).
 		FoundriesToGenerate(1).MustBuild()
 
-	// build foundry output, consume all amount from the UTXO output
+	// build foundry output
 	foundryID, _ := iotago.FoundryIDFromAddressAndSerialNumberAndTokenScheme(accAddr, accTransitionOutput.FoundryCounter, iotago.TokenSchemeSimple)
 	tokenScheme := &iotago.SimpleTokenScheme{
 		MintedTokens:  big.NewInt(int64(mintedAmount)),

tools/docker-network/tests/dockerframework.go

@@ -501,7 +501,8 @@ func (d *DockerTestFramework) CreateNativeToken(from *Account) (updatedAccount *
 		FoundriesToGenerate(1).MustBuild()
 
 	// build foundry output, consume all amount from the UTXO output
-	foundryID, _ := iotago.FoundryIDFromAddressAndSerialNumberAndTokenScheme(from.AccountAddress, accTransitionOutput.FoundryCounter, iotago.TokenSchemeSimple)
+	foundryID, err := iotago.FoundryIDFromAddressAndSerialNumberAndTokenScheme(from.AccountAddress, accTransitionOutput.FoundryCounter, iotago.TokenSchemeSimple)
+	require.NoError(d.Testing, err)
 	tokenScheme := &iotago.SimpleTokenScheme{
 		MintedTokens:  big.NewInt(int64(mintedAmount)),
 		MaximumSupply: big.NewInt(int64(mintedAmount)),