Merge branch 'develop' of github.com:iotaledger/iota-core into test-scenario

Author: muXxer

.github/workflows/build_tools.yml

@@ -24,4 +24,4 @@ jobs:
 
       - name: Build genesis-snapshot tool
         working-directory: tools/genesis-snapshot
-        run: go mod tidy && go build .
+        run: go build .

.github/workflows/feature-network-deploy.yml

@@ -44,7 +44,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version-file: 'tools/genesis-snapshot/go.mod'
+          go-version-file: 'go.mod'
           cache: false
 
       - name: Print Go version

.github/workflows/golangci-lint.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Checkout custom linter
         uses: actions/checkout@v4
         with:
-          repository: karimodm/typegroupingcheck
+          repository: muxxer/typegroupingcheck
           path: typegroupingcheck 
 
       - name: Setup go

.github/workflows/unit-test-nightly.yml

@@ -0,0 +1,45 @@
+name: Unit tests nightly
+
+on:
+  schedule:
+    - cron: '0 5 * * *' # Runs every day at 5 AM
+  workflow_dispatch:
+  
+jobs:
+  unit-tests-with-log:
+    name: Unit tests with log nightly
+    runs-on: self-hosted
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: 'go.mod'
+          cache: false
+
+      - name: Print Go version
+        run: go version
+
+      - name: Run unit tests with logger (level trace)
+        run: |
+            CI_UNIT_TESTS_LOG_LEVEL=trace go test ./... -tags rocksdb -count=5 -race -short -timeout 120m
+
+  unit-tests-without-log:
+    name: Unit tests without log nightly
+    runs-on: self-hosted
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: 'go.mod'
+          cache: false
+
+      - name: Print Go version
+        run: go version
+
+      - name: Run unit tests without logger 
+        run: |
+            CI_UNIT_NO_LOG=1 go test ./... -tags rocksdb -count=5 -race -short -timeout 120m

README.md

@@ -8,6 +8,7 @@ IOTA-Core is the node software for the upcoming IOTA 2.0 protocol.
 ![GitHub License](https://img.shields.io/github/license/iotaledger/iota-core?branch=develop)
 ---
 [![unit-test](https://github.com/iotaledger/iota-core/actions/workflows/unit-test.yml/badge.svg?branch=develop)](https://github.com/iotaledger/iota-core/actions/workflows/unit-test.yml)
+[![unit-test-nightly](https://github.com/iotaledger/iota-core/actions/workflows/unit-test-nightly.yml/badge.svg?branch=develop)](https://github.com/iotaledger/iota-core/actions/workflows/unit-test-nightly.yml)
 [![build_docker](https://github.com/iotaledger/iota-core/actions/workflows/build_docker.yml/badge.svg?branch=develop)](https://github.com/iotaledger/iota-core/actions/workflows/build_docker.yml)
 [![docker-network-health](https://github.com/iotaledger/iota-core/actions/workflows/docker-network-health.yml/badge.svg?branch=develop)](https://github.com/iotaledger/iota-core/actions/workflows/docker-network-health.yml)
 [![docker-network-tests-nightly](https://github.com/iotaledger/iota-core/actions/workflows/docker-network-tests-nightly.yml/badge.svg?branch=develop)](https://github.com/iotaledger/iota-core/actions/workflows/docker-network-tests-nightly.yml)

components/app/app.go

@@ -25,7 +25,7 @@ var (
 	Name = "iota-core"
 
 	// Version of the app.
-	Version = "1.0.0-alpha.3"
+	Version = "1.0.0-alpha.6"
 )
 
 func App() *app.App {

components/debugapi/commitment.go

@@ -69,18 +69,22 @@ func prepareCommitmentGraph(g *graphviz.Graphviz, rootCommitment *protocol.Commi
 			return nil, parentErr
 		}
 
-		if err = parentCommitment.Children.ForEach(func(childCommitment *protocol.Commitment) error {
-			child, childErr := createNode(graph, childCommitment)
-			if childErr != nil {
-				return childErr
-			}
+		// TODO: this should be removed once eviction of commitments is properly implemented
+		if parentCommitment.Children.IsEmpty() {
+			if childCommitment, exists := parentCommitment.Chain.Get().Commitment(parentCommitment.Slot() + 1); exists {
+				if err = renderChild(childCommitment, graph, parentCommitment, parent); err != nil {
+					return nil, err
+				}
 
-			if childCommitment.Chain.Get() == deps.Protocol.Chains.Main.Get() {
-				child.SetColor("green")
+				commitmentWalker.Push(childCommitment)
+
+				continue
 			}
+		}
 
-			if _, edgeErr := graph.CreateEdge(fmt.Sprintf("%s -> %s", parentCommitment.ID().String()[:8], childCommitment.ID().String()[:8]), parent, child); edgeErr != nil {
-				return ierrors.Wrapf(edgeErr, "could not create edge %s -> %s", parentCommitment.ID().String()[:8], childCommitment.ID().String()[:8])
+		if err = parentCommitment.Children.ForEach(func(childCommitment *protocol.Commitment) error {
+			if err = renderChild(childCommitment, graph, parentCommitment, parent); err != nil {
+				return err
 			}
 
 			commitmentWalker.Push(childCommitment)
@@ -94,6 +98,23 @@ func prepareCommitmentGraph(g *graphviz.Graphviz, rootCommitment *protocol.Commi
 	return graph, nil
 }
 
+func renderChild(childCommitment *protocol.Commitment, graph *cgraph.Graph, parentCommitment *protocol.Commitment, parent *cgraph.Node) error {
+	child, err := createNode(graph, childCommitment)
+	if err != nil {
+		return err
+	}
+
+	if childCommitment.Chain.Get() == deps.Protocol.Chains.Main.Get() {
+		child.SetColor("green")
+	}
+
+	if _, edgeErr := graph.CreateEdge(fmt.Sprintf("%s -> %s", parentCommitment.ID().String()[:8], childCommitment.ID().String()[:8]), parent, child); edgeErr != nil {
+		return ierrors.Wrapf(edgeErr, "could not create edge %s -> %s", parentCommitment.ID().String()[:8], childCommitment.ID().String()[:8])
+	}
+
+	return nil
+}
+
 func createNode(graph *cgraph.Graph, commitment *protocol.Commitment) (*cgraph.Node, error) {
 	node, err := graph.CreateNode(fmt.Sprintf("%d-%s", commitment.ID().Slot(), commitment.ID().Identifier().String()[:8]))
 	if err != nil {

components/debugapi/component.go

@@ -48,7 +48,7 @@ func init() {
 		DepsFunc:  func(cDeps dependencies) { deps = cDeps },
 		Configure: configure,
 		Params:    params,
-		IsEnabled: func(c *dig.Container) bool {
+		IsEnabled: func(_ *dig.Container) bool {
 			return restapi.ParamsRestAPI.Enabled && ParamsDebugAPI.Enabled
 		},
 	}
@@ -90,11 +90,13 @@ func configure() error {
 
 	routeGroup := deps.RestRouteManager.AddRoute("debug/v2")
 
+	debugAPIWorkerPool := workerpool.NewGroup("DebugAPI").CreatePool("DebugAPI", workerpool.WithWorkerCount(1))
+
 	deps.Protocol.Events.Engine.BlockDAG.BlockAttached.Hook(func(block *blocks.Block) {
 		blocksPerSlot.Set(block.ID().Slot(), append(lo.Return1(blocksPerSlot.GetOrCreate(block.ID().Slot(), func() []*blocks.Block {
 			return make([]*blocks.Block, 0)
 		})), block))
-	})
+	}, event.WithWorkerPool(debugAPIWorkerPool))
 
 	deps.Protocol.Events.Engine.SlotGadget.SlotFinalized.Hook(func(index iotago.SlotIndex) {
 		epoch := deps.Protocol.APIForSlot(index).TimeProvider().EpochFromSlot(index)
@@ -113,23 +115,24 @@ func configure() error {
 			}
 		}
 
-	}, event.WithWorkerPool(workerpool.NewGroup("DebugAPI").CreatePool("PruneDebugAPI", workerpool.WithWorkerCount(1))))
+	}, event.WithWorkerPool(debugAPIWorkerPool))
 
 	deps.Protocol.Events.Engine.Notarization.SlotCommitted.Hook(func(scd *notarization.SlotCommittedDetails) {
 		if err := storeTransactionsPerSlot(scd); err != nil {
 			Component.LogWarnf(">> DebugAPI Error: %s\n", err)
 		}
-	})
+	}, event.WithWorkerPool(debugAPIWorkerPool))
 
-	deps.Protocol.Events.Engine.EvictionState.SlotEvicted.Hook(func(index iotago.SlotIndex) {
+	deps.Protocol.Events.Engine.Evict.Hook(func(index iotago.SlotIndex) {
 		blocksInSlot, exists := blocksPerSlot.Get(index)
 		if !exists {
 			return
 		}
 
 		for _, block := range blocksInSlot {
 			if block.ProtocolBlock() == nil {
-				Component.LogInfof("block is a root block", block.ID())
+				Component.LogInfof("block is a root block %s", block.ID())
+
 				continue
 			}
 
@@ -146,7 +149,7 @@ func configure() error {
 		}
 
 		blocksPerSlot.Delete(index)
-	})
+	}, event.WithWorkerPool(debugAPIWorkerPool))
 
 	routeGroup.GET(RouteBlockMetadata, func(c echo.Context) error {
 		blockID, err := httpserver.ParseBlockIDParam(c, api.ParameterBlockID)

components/debugapi/transactions.go

@@ -4,7 +4,6 @@ import (
 	"github.com/iotaledger/hive.go/ads"
 	"github.com/iotaledger/hive.go/ierrors"
 	"github.com/iotaledger/hive.go/kvstore/mapdb"
-	"github.com/iotaledger/iota-core/pkg/protocol/engine/mempool"
 	"github.com/iotaledger/iota-core/pkg/protocol/engine/notarization"
 	iotago "github.com/iotaledger/iota.go/v4"
 )
@@ -17,10 +16,7 @@ func init() {
 
 func storeTransactionsPerSlot(scd *notarization.SlotCommittedDetails) error {
 	slot := scd.Commitment.Slot()
-	stateDiff, err := deps.Protocol.Engines.Main.Get().Ledger.MemPool().StateDiff(slot)
-	if err != nil {
-		return ierrors.Wrapf(err, "failed to retrieve state diff for slot %d", slot)
-	}
+
 	mutationsTree := ads.NewSet[iotago.Identifier](
 		mapdb.NewMapDB(),
 		iotago.Identifier.Bytes,
@@ -33,23 +29,24 @@ func storeTransactionsPerSlot(scd *notarization.SlotCommittedDetails) error {
 		IncludedTransactions: make([]string, 0),
 	}
 
-	var innerErr error
-	stateDiff.ExecutedTransactions().ForEach(func(_ iotago.TransactionID, txMeta mempool.TransactionMetadata) bool {
-		tcs.IncludedTransactions = append(tcs.IncludedTransactions, txMeta.ID().String())
-		if err := mutationsTree.Add(txMeta.ID()); err != nil {
-			innerErr = ierrors.Wrapf(err, "failed to add transaction to mutations tree, txID: %s", txMeta.ID())
+	for _, transaction := range scd.Mutations {
+		txID, err := transaction.ID()
+		if err != nil {
+			return ierrors.Wrapf(err, "failed to calculate transactionID")
+		}
 
-			return false
+		tcs.IncludedTransactions = append(tcs.IncludedTransactions, txID.String())
+		if err = mutationsTree.Add(txID); err != nil {
+			return ierrors.Wrapf(err, "failed to add transaction to mutations tree, txID: %s", txID)
 		}
 
-		return true
-	})
+	}
 
 	tcs.MutationsRoot = mutationsTree.Root().String()
 
 	transactionsPerSlot[slot] = tcs
 
-	return innerErr
+	return nil
 }
 
 func getSlotTransactionIDs(slot iotago.SlotIndex) (*TransactionsChangesResponse, error) {

components/inx/component.go

@@ -19,7 +19,7 @@ func init() {
 		Name:     "INX",
 		DepsFunc: func(cDeps dependencies) { deps = cDeps },
 		Params:   params,
-		IsEnabled: func(c *dig.Container) bool {
+		IsEnabled: func(_ *dig.Container) bool {
 			return ParamsINX.Enabled
 		},
 		Provide: provide,