Skip to content

Todos #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abdulmth opened this issue Dec 3, 2023 · 1 comment
Closed

Todos #3

abdulmth opened this issue Dec 3, 2023 · 1 comment

Comments

@abdulmth
Copy link
Contributor

abdulmth commented Dec 3, 2023

  1. Add test vectors with decoys from the specs comment
  2. State in the Hasher trait, that users are expected to only implement Hashers whose alg_name returns a value from the list mentioned in the spec comment.
  3. Replace all occurences of _sd_alg with a constant defined somewhere comment.
  4. Use constant salt size comment.
  5. Implement try_from_serializable instead of impl TryFrom<Value> for SdObjectEncoder comment
  6. Remove returned disclosures from decoys comment
  7. Generate > 128 random bytes first, then encode them to base64 later to get a string comment
  8. Fix random string generation by generating128 bits of cryptographically secure random data and then base64url-encode them. comment
  9. improve digest_b64_url_only_ascii comment
  10. Fix unnecessary ASCII filtering comment
  11. Feature gate sha hasher
@abdulmth abdulmth changed the title Add test vectors with decoys. Add test vectors with decoys Dec 3, 2023
@abdulmth abdulmth changed the title Add test vectors with decoys Todos Dec 3, 2023
This was referenced Dec 3, 2023
@abdulmth
Copy link
Contributor Author

abdulmth commented Dec 6, 2023

done in #4

@abdulmth abdulmth closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant