Add Package.swift for Swift Package Manager support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Halvorson <[email protected]>
|
+1 |
1 similar comment
|
+1 |
|
Just gonna close this as it's been over 2 years now since I opened it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14
Seeing as this library is distributed as a binary XCFramework, it would be great to have Swift Package Manager as an option for installing it. All that should be needed is the addition of a simple
Package.swiftfile to the repo.Looks like there are quite a few teams that would appreciate having SPM support, so hopefully this feels worth doing. Thanks!
Testing
I've worked up an example that may be enough. I was able to add the library to an existing project of mine, and confirmed that the project built with this as a dependency. My team is just exploring using this library though, so we have not yet implemented it in our project, meaning I am not able to actually test the library.