Merge pull request juergenH87#29 from snideto/feature/memory_access

correct indexing for received data conversion

Author: snideto

j1939/memory_access.py

@@ -145,7 +145,7 @@ def _bytes_to_values(self, raw_bytes):
         for i in range(len(raw_bytes) // self.object_byte_size):
             values.append(
                 int.from_bytes(
-                    raw_bytes[i : self.object_byte_size - 1],
+                    raw_bytes[i : self.object_byte_size],
                     byteorder="little",
                     signed=self.signed,
                 )

test/feeder.py

@@ -13,9 +13,9 @@
 class AcceptAllCA(j1939.ControllerApplication):
     """CA to accept all messages"""
 
-    def __init__(self, name, device_address_preferred=None):
+    def __init__(self, name, device_address_preferred, bypass_address_claim):
         # old fashion calling convention for compatibility with Python2
-        j1939.ControllerApplication.__init__(self, name, device_address_preferred)
+        j1939.ControllerApplication.__init__(self, name, device_address_preferred, bypass_address_claim)
 
     def message_acceptable(self, dest_address):
         """Indicates if this CA would accept a message
@@ -115,13 +115,9 @@ def accept_all_messages(
         self, device_address_preferred=None, bypass_address_claim=False
     ):
         # install a fake-CA to accept all messages
-        ca = AcceptAllCA(None, device_address_preferred=device_address_preferred)
+        ca = AcceptAllCA(None, device_address_preferred, bypass_address_claim)
 
         self.ecu.add_ca(controller_application=ca)
-        if bypass_address_claim:  # hack
-            ca._device_address = device_address_preferred
-            ca._device_address_state = j1939.ControllerApplication.State.NORMAL
-            self.ecu.subscribe(self._on_message)
         return ca
 
     def receive(self):