Skip to content

Commit dadb3da

Browse files
committed
more strict mypy
1 parent 36a9525 commit dadb3da

17 files changed

+78
-33
lines changed

ipykernel/comm/comm.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717

1818
# this is the class that will be created if we do comm.create_comm
19-
class BaseComm(comm.base_comm.BaseComm): # type:ignore[misc]
19+
class BaseComm(comm.base_comm.BaseComm):
2020
"""The base class for comms."""
2121

2222
kernel: Optional["Kernel"] = None
@@ -90,7 +90,7 @@ def __init__(
9090
kernel = kwargs.pop("kernel", None)
9191
if target_name:
9292
kwargs["target_name"] = target_name
93-
BaseComm.__init__(self, data=data, metadata=metadata, buffers=buffers, **kwargs) # type:ignore[call-arg]
93+
BaseComm.__init__(self, data=data, metadata=metadata, buffers=buffers, **kwargs)
9494
# only re-add kernel if explicitly provided
9595
if had_kernel:
9696
kwargs["kernel"] = kernel

ipykernel/comm/manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
logger = logging.getLogger("ipykernel.comm")
1515

1616

17-
class CommManager(comm.base_comm.CommManager, traitlets.config.LoggingConfigurable): # type:ignore[misc]
17+
class CommManager(comm.base_comm.CommManager, traitlets.config.LoggingConfigurable):
1818
"""A comm manager."""
1919

2020
kernel = traitlets.Instance("ipykernel.kernelbase.Kernel")

ipykernel/datapub.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
try:
1515
# available since ipyparallel 5.0.0
16-
from ipyparallel.serialize import serialize_object
16+
from ipyparallel.serialize import serialize_object # type: ignore[import-not-found]
1717
except ImportError:
1818
# Deprecated since ipykernel 4.3.0
1919
from ipykernel.serialize import serialize_object

ipykernel/debugger.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@
2323
# This import is required to have the next ones working...
2424
from debugpy.server import api # noqa: F401
2525

26-
from _pydevd_bundle import pydevd_frame_utils # isort: skip
27-
from _pydevd_bundle.pydevd_suspended_frames import ( # isort: skip
26+
from _pydevd_bundle import ( # type:ignore[import-not-found]
27+
pydevd_frame_utils,
28+
) # isort: skip
29+
from _pydevd_bundle.pydevd_suspended_frames import ( # type:ignore[import-not-found] # isort: skip
2830
SuspendedFramesManager,
2931
_FramesTracker,
3032
)
@@ -70,7 +72,7 @@ class _DummyPyDB:
7072

7173
def __init__(self):
7274
"""Init."""
73-
from _pydevd_bundle.pydevd_api import PyDevdAPI
75+
from _pydevd_bundle.pydevd_api import PyDevdAPI # type: ignore[import-not-found]
7476

7577
self.variable_presentation = PyDevdAPI.VariablePresentation()
7678

ipykernel/eventloops.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ def _loop_wx(app):
172172
def loop_wx(kernel):
173173
"""Start a kernel with wx event loop support."""
174174

175-
import wx
175+
import wx # type: ignore[import-not-found]
176176

177177
# Wx uses milliseconds
178178
poll_interval = int(1000 * kernel._poll_interval)
@@ -515,19 +515,19 @@ def set_qt_api_env_from_gui(gui):
515515
os.environ["QT_API"] = "pyqt5"
516516
except ImportError:
517517
try:
518-
import PySide2 # noqa: F401
518+
import PySide2 # type: ignore[import-not-found] #noqa: F401
519519

520520
os.environ["QT_API"] = "pyside2"
521521
except ImportError:
522522
os.environ["QT_API"] = "pyqt5"
523523
elif gui == "qt6":
524524
try:
525-
import PyQt6 # noqa: F401
525+
import PyQt6 # type: ignore[import-not-found] #noqa: F401
526526

527527
os.environ["QT_API"] = "pyqt6"
528528
except ImportError:
529529
try:
530-
import PySide6 # noqa: F401
530+
import PySide6 # type: ignore[import-not-found] # noqa: F401
531531

532532
os.environ["QT_API"] = "pyside6"
533533
except ImportError:

ipykernel/gui/gtk3embed.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
import warnings
1616

1717
# Third-party
18-
import gi
18+
import gi # type: ignore[import-not-found]
1919

2020
gi.require_version("Gdk", "3.0")
2121
gi.require_version("Gtk", "3.0")
22-
from gi.repository import GObject, Gtk # noqa: E402
22+
from gi.repository import GObject, Gtk # type: ignore[import-not-found] # noqa: E402
2323

2424
warnings.warn(
2525
"The Gtk3 event loop for ipykernel is deprecated", category=DeprecationWarning, stacklevel=2

ipykernel/gui/gtkembed.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
import warnings
1616

1717
# Third-party
18-
import gobject
19-
import gtk
18+
import gobject # type: ignore[import-not-found]
19+
import gtk # type: ignore[import-not-found]
2020

2121
warnings.warn(
2222
"The Gtk3 event loop for ipykernel is deprecated", category=DeprecationWarning, stacklevel=2

ipykernel/inprocess/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def _default_blocking_class(self):
5555

5656
return BlockingInProcessKernelClient
5757

58-
def get_connection_info(self): # type: ignore[override]
58+
def get_connection_info(self):
5959
"""Get the connection info for the client."""
6060
d = super().get_connection_info()
6161
d["kernel"] = self.kernel # type:ignore[assignment]
@@ -100,7 +100,7 @@ def hb_channel(self):
100100
# Methods for sending specific messages
101101
# -------------------------------------
102102

103-
async def execute( # type: ignore[override]
103+
async def execute(
104104
self,
105105
code,
106106
silent=False,

ipykernel/inprocess/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33

44
class Session(_Session):
5-
async def recv(self, socket, copy=True): # type: ignore [override]
5+
async def recv(self, socket, copy=True):
66
return await socket.recv_multipart()
77

88
def send(

ipykernel/ipkernel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,7 +641,7 @@ def do_is_complete(self, code):
641641
def do_apply(self, content, bufs, msg_id, reply_metadata):
642642
"""Handle an apply request."""
643643
try:
644-
from ipyparallel.serialize import serialize_object, unpack_apply_message
644+
from ipyparallel.serialize import serialize_object, unpack_apply_message # type: ignore[import-not-found]
645645
except ImportError:
646646
from .serialize import serialize_object, unpack_apply_message
647647

0 commit comments

Comments
 (0)