Skip to content

Commit 8e15fa6

Browse files
authored
Merge pull request Ada-C14#9 from AdaGold/ddr/rubric
rubric: new format, comp qs -> reflection
2 parents e0707f9 + e227215 commit 8e15fa6

File tree

2 files changed

+54
-24
lines changed

2 files changed

+54
-24
lines changed

.github/PULL_REQUEST_TEMPLATE

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
# Adagrams
2-
Congratulations! You're submitting your assignment.
1+
# Assignment Submission: Adagrams
32

4-
## Comprehension Questions
3+
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
4+
5+
## Reflection
56

67
Feature | Feedback
78
--- | ---

feedback.md

+50-21
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,50 @@
1-
# Adagrams
2-
## What We're Looking For
3-
4-
Feature | Feedback
5-
--- | ---
6-
**General** |
7-
Answered comprehension questions |
8-
Small commits with meaningful commit messages |
9-
**Code Requirements** |
10-
`draw_letters` method |
11-
Uses appropriate data structure to store the letter distribution |
12-
All tests for `draw_letters` pass |
13-
`uses_available_letters?` method |
14-
All tests for `uses_available_letters?` pass |
15-
`score_word` method |
16-
Uses appropriate data structure to store the letter scores |
17-
All tests for `score_word` pass |
18-
`highest_score_from` method |
19-
Appropriately handles edge cases for tie-breaking logic |
20-
All tests for `highest_score_from` pass |
21-
**Overall** |
1+
# Calculator
2+
3+
<!-- Instructors: The checkmarks are already there, so just delete them for any line items that aren't met. -->
4+
5+
## Major Learning Goals/Code Review
6+
7+
<!-- Instructors: Feel free to practice creating specific feedback by referencing a line of code if you'd like. For example, you may say something like "nice custom method in `calculator.rb` line 42." This is optional. -->
8+
9+
| Criteria | yes/no, and optionally any details/lines of code to reference |
10+
| --- | --- |
11+
| Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) | ✔️
12+
| Uses correct syntax for conditional logic and iteration | ✔️
13+
| Practices git with at least 3 small commits and meaningful commit messages | ✔️
14+
| Utilizes unit tests to verify code; tests can run using the command `$ rake` and we see test successes and/or failures | ✔️
15+
| Practices pair programming; the reflection question on pair programming is answered | ✔️
16+
17+
## Functional Requirements
18+
19+
| Functional Requirement | yes/no |
20+
| --- | --- |
21+
| For the `draw_letters` method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) | ✔️
22+
| Utilizes unit tests to verify code; all tests for `draw_letters` and `uses_available_letters?` pass | ✔️
23+
| Utilizes unit tests to verify code; all tests for `score_word` pass | ✔️
24+
| Utilizes unit tests to verify code; all tests for `highest_score_from` pass | ✔️
25+
26+
## Overall Feedback
27+
28+
| Overall Feedback | Criteria | yes/no |
29+
| --- | --- | --- |
30+
| Green (Meets/Exceeds Standards) | 4+ in Code Review && 3+ in Functional Requirements | ✔️
31+
| Yellow (Approaches Standards) | 3+ in Code Review && 2+ in Functional Requirements | ✔️
32+
| Red (Not at Standard) | 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging | ✔️
33+
34+
<!-- ### Additional Feedback -->
35+
36+
<!-- Instructors, feel free to ignore this section if there's nothing else to add. -->
37+
38+
## Code Style Bonus Awards
39+
40+
<!-- Instructors: Please strike a balance between liberal/stingy with these. These are simply built-in pieces of positive feedback; use this to encourage and push students towards a cleaner code style! -->
41+
42+
Was the code particularly impressive in code style for any of these reasons (or more...?)
43+
44+
| Quality | Yes? |
45+
| --- | --- |
46+
| Perfect Indentation | ✅
47+
| Elegant/Clever | ✅
48+
| Descriptive/Readable | ✅
49+
| Concise | ✅
50+
| Logical/Organized | ✅

0 commit comments

Comments
 (0)