Skip to content

Commit 70f685e

Browse files
committed
feat: remove date config for chainport upgrade
1 parent 7442b19 commit 70f685e

File tree

7 files changed

+11
-88
lines changed

7 files changed

+11
-88
lines changed

main/api/chainport/handleSendChainportBridgeTransaction.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@ import { z } from "zod";
44
import {
55
buildTransactionRequestParams,
66
buildTransactionRequestParamsInputs,
7-
isBridgeFeeV1,
8-
isBridgeFeeV2,
97
} from "./utils/buildTransactionRequestParams";
10-
import { getConfig } from "./vendor/config";
118
import { manager } from "../manager";
129

1310
export const handleSendChainportBridgeTransactionInput =
@@ -22,22 +19,6 @@ export async function handleSendChainportBridgeTransaction({
2219
}: z.infer<typeof handleSendChainportBridgeTransactionInput>) {
2320
const ironfish = await manager.getIronfish();
2421
const rpcClient = await ironfish.rpcClient();
25-
const currentNetwork = (await rpcClient.chain.getNetworkInfo()).content
26-
.networkId;
27-
const config = getConfig(currentNetwork);
28-
const isBridgeFeeUpgradeActivated =
29-
new Date(config.bridgeFeeUpgrade) < new Date();
30-
const bridgeFeeV1 = isBridgeFeeV1(txDetails);
31-
const bridgeFeeV2 = isBridgeFeeV2(txDetails);
32-
if (isBridgeFeeUpgradeActivated) {
33-
if (!bridgeFeeV2) {
34-
throw new Error("Unsupported bridge fee version");
35-
}
36-
} else {
37-
if (!bridgeFeeV1) {
38-
throw new Error("Unsupported bridge fee version");
39-
}
40-
}
4122

4223
const params = buildTransactionRequestParams({
4324
fromAccount,

main/api/chainport/utils/buildTransactionRequestParams.ts

Lines changed: 7 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,12 @@ export const buildTransactionRequestParamsInputs = z.object({
1515
amount: z.string(),
1616
memo: z.string(),
1717
}),
18-
bridge_fee: z.union([
19-
z.object({
20-
source_token_fee_amount: z.string(),
21-
portx_fee_amount: z.string(),
22-
is_portx_fee_payment: z.boolean(),
23-
}),
24-
z.object({
25-
publicAddress: z.string(),
26-
source_token_fee_amount: z.string(),
27-
memo: z.string(),
28-
assetId: z.string(),
29-
}),
30-
]),
18+
bridge_fee: z.object({
19+
publicAddress: z.string(),
20+
source_token_fee_amount: z.string(),
21+
memo: z.string(),
22+
assetId: z.string(),
23+
}),
3124
}),
3225
fee: z.number().optional(),
3326
feeRate: z.string().optional(),
@@ -37,40 +30,6 @@ export type BuildTransactionRequestParamsInputs = z.infer<
3730
typeof buildTransactionRequestParamsInputs
3831
>;
3932

40-
export function isBridgeFeeV1(
41-
txDetails: BuildTransactionRequestParamsInputs["txDetails"],
42-
): txDetails is BuildTransactionRequestParamsInputs["txDetails"] & {
43-
bridge_fee: {
44-
source_token_fee_amount: string;
45-
portx_fee_amount: string;
46-
is_portx_fee_payment: boolean;
47-
};
48-
} {
49-
return (
50-
"is_portx_fee_payment" in txDetails.bridge_fee &&
51-
"source_token_fee_amount" in txDetails.bridge_fee &&
52-
"portx_fee_amount" in txDetails.bridge_fee
53-
);
54-
}
55-
56-
export function isBridgeFeeV2(
57-
txDetails: BuildTransactionRequestParamsInputs["txDetails"],
58-
): txDetails is BuildTransactionRequestParamsInputs["txDetails"] & {
59-
bridge_fee: {
60-
publicAddress: string;
61-
assetId: string;
62-
memo: string;
63-
source_token_fee_amount: string;
64-
};
65-
} {
66-
return (
67-
"publicAddress" in txDetails.bridge_fee &&
68-
"memo" in txDetails.bridge_fee &&
69-
"assetId" in txDetails.bridge_fee &&
70-
"source_token_fee_amount" in txDetails.bridge_fee
71-
);
72-
}
73-
7433
export function buildTransactionRequestParams({
7534
fromAccount,
7635
txDetails,
@@ -92,7 +51,7 @@ export function buildTransactionRequestParams({
9251
const outputs = [userOutput, gasFeeOutput];
9352

9453
const bridgeFee = txDetails.bridge_fee.source_token_fee_amount;
95-
if (isBridgeFeeV2(txDetails) && BigInt(bridgeFee) > 0n) {
54+
if (BigInt(bridgeFee) > 0n) {
9655
userOutput.amount = (
9756
BigInt(userOutput.amount) - BigInt(bridgeFee)
9857
).toString();

main/api/chainport/vendor/config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ const config = {
1515
incomingAddresses: new Set([
1616
"06102d319ab7e77b914a1bd135577f3e266fd82a3e537a02db281421ed8b3d13",
1717
]),
18-
bridgeFeeUpgrade: new Date("2025-07-01T00:00:00Z"),
1918
},
2019
[MAINNET.id]: {
2120
endpoint: "https://api.ironfish.network",
@@ -26,7 +25,6 @@ const config = {
2625
incomingAddresses: new Set([
2726
"1216302193e8f1ad020f458b54a163039403d803e98673c6a85e59b5f4a1a900",
2827
]),
29-
bridgeFeeUpgrade: new Date("2025-07-15T00:00:00Z"),
3028
},
3129
};
3230

main/api/chainport/vendor/requests.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,12 @@ export const fetchChainportBridgeTransaction = async (
6767
sourceAddress: string,
6868
): Promise<ChainportBridgeTransaction> => {
6969
const config = getConfig(networkId);
70-
const isBridgeFeeUpgradeActivated =
71-
new Date(config.bridgeFeeUpgrade) < new Date();
7270
const url = new URL(`/bridges/transactions/create`, config.endpoint);
7371
url.searchParams.append("amount", amount.toString());
7472
url.searchParams.append("asset_id", assetId);
7573
url.searchParams.append("target_network_id", targetNetworkId.toString());
7674
url.searchParams.append("target_address", targetAddress.toString());
77-
if (isBridgeFeeUpgradeActivated) {
78-
url.searchParams.append("source_address", sourceAddress);
79-
}
75+
url.searchParams.append("source_address", sourceAddress);
8076

8177
return await makeChainportRequest<ChainportBridgeTransaction>(url.toString());
8278
};

main/api/chainport/vendor/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export type ChainportBridgeTransaction = {
2929
amount: string;
3030
memo: string;
3131
};
32-
bridge_fee: ChainportBridgeFeeV1 | ChainportBridgeFeeV2;
32+
bridge_fee: ChainportBridgeFeeV2;
3333
};
3434

3535
export type ChainportNetwork = {

main/api/chainport/vendor/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const extractChainportDataFromTransaction = (
3636

3737
const getIncomingChainportTransactionData = (
3838
transaction: RpcWalletTransaction,
39-
config: { incomingAddresses: Set<string>; bridgeFeeUpgrade: Date },
39+
config: { incomingAddresses: Set<string> },
4040
): ChainportTransactionData => {
4141
const bridgeNote = transaction.notes?.[0];
4242

@@ -60,7 +60,7 @@ const getIncomingChainportTransactionData = (
6060

6161
const getOutgoingChainportTransactionData = (
6262
transaction: RpcWalletTransaction,
63-
config: { outgoingAddresses: Set<string>; bridgeFeeUpgrade: Date },
63+
config: { outgoingAddresses: Set<string> },
6464
): ChainportTransactionData => {
6565
if (!transaction.notes || transaction.notes.length < 2) {
6666
return undefined;

renderer/components/BridgeAssetsForm/BridgeConfirmationModal/BridgeConfirmationModal.tsx

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -211,17 +211,6 @@ export function BridgeConfirmationModal({
211211
return <Skeleton>123 FOO</Skeleton>;
212212
}
213213

214-
if (
215-
"is_portx_fee_payment" in txDetails.bridge_fee &&
216-
txDetails.bridge_fee.is_portx_fee_payment
217-
) {
218-
const fee = CurrencyUtils.formatCurrency(
219-
txDetails.bridge_fee.portx_fee_amount,
220-
18,
221-
);
222-
return `${fee} PORTX`;
223-
}
224-
225214
return `${CurrencyUtils.formatCurrency(
226215
txDetails.bridge_fee.source_token_fee_amount,
227216
chainportToken.decimals,

0 commit comments

Comments
 (0)