Names an account with last 4 of address if no name exists (#301)

Author: cgjohn

main/api/manager.ts

@@ -1,4 +1,5 @@
 import { RpcClient } from "@ironfish/sdk";
+import log from "electron-log";
 
 import { getExternalChainHead } from "./accounts/utils/getExternalChainHead";
 import { Ironfish } from "./ironfish/Ironfish";
@@ -46,6 +47,58 @@ export class Manager {
     return hoursSinceLastBlock > 24 * 7 * 2;
   };
 
+  private async handleUnnamedAccounts(
+    rpcClient: RpcClient,
+    accountsResponse: { content: { accounts: string[] } },
+  ) {
+    // Create a set of existing account names and find unnamed accounts in one pass
+    const existingNames = new Set<string>();
+    const unnamedAccounts = accountsResponse.content.accounts.filter(
+      (account) => {
+        existingNames.add(account);
+        if (account.trim()) {
+          return false;
+        }
+        return true;
+      },
+    );
+
+    // Handle each unnamed account sequentially
+    for (const account of unnamedAccounts) {
+      const publicKey = await rpcClient.wallet.getAccountPublicKey({
+        account,
+      });
+      const accountAddress = publicKey.content.publicKey;
+      let newName = `account-${accountAddress.slice(0, 4)}`;
+      try {
+        const MAX_ATTEMPTS = 5;
+        let attempts = 0;
+        while (existingNames.has(newName) && attempts < MAX_ATTEMPTS) {
+          const randomString = `-${Math.floor(Math.random() * 100000)
+            .toString()
+            .padStart(5, "0")}`;
+          newName = `${newName}${randomString}`;
+          attempts++;
+        }
+
+        if (attempts === MAX_ATTEMPTS && existingNames.has(newName)) {
+          const errorMsg =
+            "Could not generate unique account name after maximum attempts";
+          log.error(errorMsg);
+          throw new Error(errorMsg);
+        }
+
+        existingNames.add(newName); // Add the new name to the set
+        await rpcClient.wallet.renameAccount({
+          account,
+          newName,
+        });
+      } catch (error) {
+        log.error(`Failed to rename account ${accountAddress}: ${error}`);
+      }
+    }
+  }
+
   async getInitialState(): Promise<InitialState> {
     const ironfish = await this.getIronfish();
 
@@ -62,6 +115,9 @@ export class Manager {
 
     const accountsResponse = await rpcClient.wallet.getAccounts();
 
+    // Pass accountsResponse to handleUnnamedAccounts
+    await this.handleUnnamedAccounts(rpcClient, accountsResponse);
+
     if (accountsResponse.content.accounts.length === 0) {
       return "onboarding";
     }