clarify arg/flag names to better indicate what resource it is acting on (#5274)

Author: mat-if

ironfish-cli/src/commands/wallet/create.ts

@@ -11,7 +11,7 @@ export class CreateCommand extends IronfishCommand {
   static description = `Create a new account for sending and receiving coins`
 
   static args = {
-    account: Args.string({
+    name: Args.string({
       required: false,
       description: 'Name of the account',
     }),
@@ -23,7 +23,7 @@ export class CreateCommand extends IronfishCommand {
 
   async start(): Promise<void> {
     const { args } = await this.parse(CreateCommand)
-    let name = args.account
+    let name = args.name
 
     if (!name) {
       name = await inputPrompt('Enter the name of the account', true)

ironfish-cli/src/commands/wallet/transactions.ts

@@ -36,8 +36,9 @@ export class TransactionsCommand extends IronfishCommand {
       char: 'a',
       description: 'Name of the account to get transactions for',
     }),
-    hash: Flags.string({
+    transaction: Flags.string({
       char: 't',
+      aliases: ['hash'],
       description: 'Transaction hash to get details for',
     }),
     sequence: Flags.integer({
@@ -77,7 +78,7 @@ export class TransactionsCommand extends IronfishCommand {
 
     const response = client.wallet.getAccountTransactionsStream({
       account,
-      hash: flags.hash,
+      hash: flags.transaction,
       sequence: flags.sequence,
       limit: flags.limit,
       offset: flags.offset,

ironfish-cli/src/commands/wallet/transactions/info.ts

@@ -27,7 +27,7 @@ export class TransactionInfoCommand extends IronfishCommand {
   static hiddenAliases = ['wallet:transaction']
 
   static args = {
-    hash: Args.string({
+    transaction: Args.string({
       required: true,
       description: 'Hash of the transaction',
     }),
@@ -47,7 +47,7 @@ export class TransactionInfoCommand extends IronfishCommand {
 
   async start(): Promise<void> {
     const { flags, args } = await this.parse(TransactionInfoCommand)
-    const { hash } = args
+    const { transaction: hash } = args
     // TODO: remove account arg
     const account = flags.account ? flags.account : args.account
 

ironfish-cli/src/commands/wallet/transactions/post.ts

@@ -22,7 +22,7 @@ export class TransactionsPostCommand extends IronfishCommand {
   static hiddenAliases = ['wallet:post']
 
   static args = {
-    transaction: Args.string({
+    raw_transaction: Args.string({
       description: 'The raw transaction in hex encoding',
     }),
   }
@@ -48,7 +48,7 @@ export class TransactionsPostCommand extends IronfishCommand {
 
   async start(): Promise<void> {
     const { flags, args } = await this.parse(TransactionsPostCommand)
-    let transaction = args.transaction
+    let transaction = args.raw_transaction
 
     if (!transaction) {
       transaction = await longPrompt('Enter the raw transaction in hex encoding', {

ironfish-cli/src/commands/wallet/transactions/watch.ts

@@ -11,7 +11,7 @@ export class TransactionsWatchCommand extends IronfishCommand {
   static hiddenAliases = ['wallet:transaction:watch']
 
   static args = {
-    hash: Args.string({
+    transaction: Args.string({
       required: true,
       description: 'Hash of the transaction',
     }),
@@ -35,7 +35,7 @@ export class TransactionsWatchCommand extends IronfishCommand {
 
   async start(): Promise<void> {
     const { flags, args } = await this.parse(TransactionsWatchCommand)
-    const { hash } = args
+    const { transaction: hash } = args
     // TODO: remove account arg
     const account = flags.account ? flags.account : args.account