makes participantName and ledger flags exclusive in dkg (#5742)

when using a ledger device the user should not need to enter a participant name
or select the participant from those in the walletDB since the identity should
be read from the ledger device

prompts the user for an account name in round3 if using a ledger

Author: hughy

ironfish-cli/src/commands/wallet/multisig/dkg/round1.ts

@@ -30,6 +30,7 @@ export class DkgRound1Command extends IronfishCommand {
     ledger: Flags.boolean({
       default: false,
       description: 'Perform operation with a ledger device',
+      exclusive: ['participantName'],
     }),
   }
 
@@ -39,11 +40,6 @@ export class DkgRound1Command extends IronfishCommand {
     const client = await this.connectRpc()
     await ui.checkWalletUnlocked(client)
 
-    let participantName = flags.participantName
-    if (!participantName) {
-      participantName = await ui.multisigSecretPrompt(client)
-    }
-
     let identities = flags.identity
     if (!identities || identities.length < 2) {
       const input = await ui.longPrompt(
@@ -74,6 +70,11 @@ export class DkgRound1Command extends IronfishCommand {
       return
     }
 
+    let participantName = flags.participantName
+    if (!participantName) {
+      participantName = await ui.multisigSecretPrompt(client)
+    }
+
     const response = await client.wallet.multisig.dkg.round1({
       participantName,
       participants: identities.map((identity) => ({ identity })),

ironfish-cli/src/commands/wallet/multisig/dkg/round2.ts

@@ -30,6 +30,7 @@ export class DkgRound2Command extends IronfishCommand {
     ledger: Flags.boolean({
       default: false,
       description: 'Perform operation with a ledger device',
+      exclusive: ['participantName'],
     }),
   }
 
@@ -39,17 +40,9 @@ export class DkgRound2Command extends IronfishCommand {
     const client = await this.connectRpc()
     await ui.checkWalletUnlocked(client)
 
-    let participantName = flags.participantName
-    if (!participantName) {
-      participantName = await ui.multisigSecretPrompt(client)
-    }
-
     let round1SecretPackage = flags.round1SecretPackage
     if (!round1SecretPackage) {
-      round1SecretPackage = await ui.inputPrompt(
-        `Enter the round 1 secret package for participant ${participantName}`,
-        true,
-      )
+      round1SecretPackage = await ui.inputPrompt('Enter your round 1 secret package', true)
     }
 
     let round1PublicPackages = flags.round1PublicPackages
@@ -73,6 +66,11 @@ export class DkgRound2Command extends IronfishCommand {
       return
     }
 
+    let participantName = flags.participantName
+    if (!participantName) {
+      participantName = await ui.multisigSecretPrompt(client)
+    }
+
     const response = await client.wallet.multisig.dkg.round2({
       participantName,
       round1SecretPackage,

ironfish-cli/src/commands/wallet/multisig/dkg/round3.ts

@@ -51,6 +51,7 @@ export class DkgRound3Command extends IronfishCommand {
     ledger: Flags.boolean({
       default: false,
       description: 'Perform operation with a ledger device',
+      exclusive: ['participantName'],
     }),
     createdAt: Flags.integer({
       description:
@@ -64,15 +65,10 @@ export class DkgRound3Command extends IronfishCommand {
     const client = await this.connectRpc()
     await ui.checkWalletUnlocked(client)
 
-    let participantName = flags.participantName
-    if (!participantName) {
-      participantName = await ui.multisigSecretPrompt(client)
-    }
-
     let round2SecretPackage = flags.round2SecretPackage
     if (!round2SecretPackage) {
       round2SecretPackage = await ui.inputPrompt(
-        `Enter the round 2 encrypted secret package for participant ${participantName}`,
+        'Enter your round 2 encrypted secret package',
         true,
       )
     }
@@ -127,9 +123,14 @@ export class DkgRound3Command extends IronfishCommand {
     }
 
     if (flags.ledger) {
+      let accountName = flags.accountName
+      if (!accountName) {
+        accountName = await ui.inputPrompt('Enter a name for the account', true)
+      }
+
       await this.performRound3WithLedger(
         client,
-        participantName,
+        accountName,
         round1PublicPackages,
         round2PublicPackages,
         round2SecretPackage,
@@ -138,6 +139,11 @@ export class DkgRound3Command extends IronfishCommand {
       return
     }
 
+    let participantName = flags.participantName
+    if (!participantName) {
+      participantName = await ui.multisigSecretPrompt(client)
+    }
+
     const response = await client.wallet.multisig.dkg.round3({
       participantName,
       accountName: flags.accountName,
@@ -155,7 +161,7 @@ export class DkgRound3Command extends IronfishCommand {
 
   async performRound3WithLedger(
     client: RpcClient,
-    participantName: string,
+    accountName: string,
     round1PublicPackagesStr: string[],
     round2PublicPackagesStr: string[],
     round2SecretPackage: string,
@@ -238,7 +244,7 @@ export class DkgRound3Command extends IronfishCommand {
         identity,
       },
       version: ACCOUNT_SCHEMA_VERSION,
-      name: participantName,
+      name: accountName,
       spendingKey: null,
       createdAt: null,
       ledger: true,
@@ -249,7 +255,7 @@ export class DkgRound3Command extends IronfishCommand {
       client,
       encodeAccountImport(accountImport, AccountFormat.Base64Json),
       this.logger,
-      participantName,
+      accountName,
       accountCreatedAt,
     )