Merge pull request #5116 from iron-fish/hotfix/2.4.1

hotfix 2.4.1

Author: hughy

.github/workflows/deploy-npm-ironfish-rust-nodejs.yml

@@ -34,7 +34,7 @@ jobs:
         run: npm install --no-workspaces
 
       - name: Download all artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           path: ironfish-rust-nodejs/artifacts
 

.github/workflows/publish-binaries.yml

@@ -51,7 +51,7 @@ jobs:
             echo "Runner architecture does not match specified architecture"
             exit 1
           fi
-      
+
       # needed for distutils, which is used by nodegyp, arm64 mac runners have 3.12
       - name: Set up Python
         uses: actions/setup-python@v3
@@ -193,7 +193,7 @@ jobs:
           xcrun notarytool submit "${{ steps.set_paths.outputs.zip }}" --keychain-profile "notarytool-profile" --wait
 
       - name: Upload artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ steps.set_paths.outputs.name }}
           path: tools/${{ steps.set_paths.outputs.zip }}

ironfish-cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ironfish",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "CLI for running and interacting with an Iron Fish node",
   "author": "Iron Fish <[email protected]> (https://ironfish.network)",
   "main": "build/src/index.js",
@@ -59,7 +59,7 @@
   },
   "dependencies": {
     "@ironfish/rust-nodejs": "2.4.0",
-    "@ironfish/sdk": "2.4.0",
+    "@ironfish/sdk": "2.4.1",
     "@oclif/core": "3.27.0",
     "@oclif/plugin-autocomplete": "1.3.10",
     "@oclif/plugin-help": "5.1.12",

ironfish/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ironfish/sdk",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "SDK for running and interacting with an Iron Fish node",
   "author": "Iron Fish <[email protected]> (https://ironfish.network)",
   "main": "build/src/index.js",

ironfish/src/wallet/scanner/scanState.ts

@@ -51,6 +51,7 @@ export class ScanState {
   }
 
   signalComplete(): void {
+    this.speed.stop()
     this.runningResolve()
   }