Skip to content

Commit fa0736c

Browse files
authored
Remove TODO around test network ID (#4429)
These were satisfied and the tests now pass
1 parent 7e28e20 commit fa0736c

File tree

3 files changed

+0
-22
lines changed

3 files changed

+0
-22
lines changed

ironfish/src/rpc/adapters/ipcAdapter.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ describe('IpcAdapter', () => {
2323
configOverrides: {
2424
enableRpc: false,
2525
enableRpcIpc: false,
26-
// TODO: It should be possible to test on the default network (mainnet)
27-
// once the genesis block has been added.
28-
networkId: 2,
2926
},
3027
})
3128

ironfish/src/rpc/adapters/tcpAdapter.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ describe('TcpAdapter', () => {
3434
enableRpcIpc: false,
3535
enableRpcTcp: false,
3636
enableRpcTls: false,
37-
// TODO: It should be possible to test on the default network (mainnet)
38-
// once the genesis block has been added.
39-
networkId: 2,
4037
rpcTcpPort: 0,
4138
},
4239
internalOverrides: {

ironfish/src/sdk.test.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,6 @@ describe('IronfishSdk', () => {
7878
configName: 'foo.config.json',
7979
dataDir: getUniqueTestDataDir(),
8080
fileSystem: fileSystem,
81-
configOverrides: {
82-
// TODO: It should be possible to test on the default network (mainnet)
83-
// once the genesis block has been added.
84-
networkId: 2,
85-
},
8681
})
8782

8883
const node = await sdk.node()
@@ -116,11 +111,6 @@ describe('IronfishSdk', () => {
116111
it('returns and connects `clientMemory` to a node', async () => {
117112
const sdk = await IronfishSdk.init({
118113
dataDir: getUniqueTestDataDir(),
119-
configOverrides: {
120-
// TODO: It should be possible to test on the default network (mainnet)
121-
// once the genesis block has been added.
122-
networkId: 2,
123-
},
124114
})
125115
const node = await sdk.node()
126116
const openDb = jest.spyOn(node, 'openDB').mockImplementationOnce(async () => {})
@@ -174,9 +164,6 @@ describe('IronfishSdk', () => {
174164
dataDir: getUniqueTestDataDir(),
175165
configOverrides: {
176166
enableRpcIpc: true,
177-
// TODO: It should be possible to test on the default network (mainnet)
178-
// once the genesis block has been added.
179-
networkId: 2,
180167
},
181168
})
182169

@@ -194,9 +181,6 @@ describe('IronfishSdk', () => {
194181
configOverrides: {
195182
enableRpcTcp: true,
196183
enableRpcTls: false,
197-
// TODO: It should be possible to test on the default network (mainnet)
198-
// once the genesis block has been added.
199-
networkId: 2,
200184
},
201185
})
202186

0 commit comments

Comments
 (0)