Add expiration and fee to createTransaction (#54)

Author: dguenther

packages/ironfish-native-module/ios/IronfishNativeModule.swift

@@ -157,13 +157,13 @@ public class IronfishNativeModule: Module {
       }
     }
 
-    AsyncFunction("createTransaction") { (transactionVersion: UInt8, spendComponents: SpendComponentsInput, outputs: OutputsInput, spendingKey: Data) throws  -> Data in
+    AsyncFunction("createTransaction") { (transactionVersion: UInt8, transactionFee: String, expirationSequence: UInt32, spendComponents: SpendComponentsInput, outputs: OutputsInput, spendingKey: Data) throws  -> Data in
       let spendComponentsConverted = spendComponents.components.map { spendComponent in
           let witnessAuthPath: [WitnessNode] = spendComponent.witnessAuthPath.map { WitnessNode(side: $0.side, hashOfSibling: Data(hexString: $0.hashOfSibling)!) }
           return SpendComponents(note: Data(hexString: spendComponent.note)!, witnessRootHash: Data(hexString: spendComponent.witnessRootHash)!, witnessTreeSize: UInt64(spendComponent.witnessTreeSize)!, witnessAuthPath: witnessAuthPath)
       }
       do {
-        let transaction = try createTransaction(transactionVersion: transactionVersion, spendComponents: spendComponentsConverted, outputs: outputs.outputs.map {Data(hexString: $0)!}, spendingKey: spendingKey)
+        let transaction = try createTransaction(transactionVersion: transactionVersion, transactionFee: UInt64(transactionFee)!, expirationSequence: expirationSequence, spendComponents: spendComponentsConverted, outputs: outputs.outputs.map {Data(hexString: $0)!}, spendingKey: spendingKey)
           return transaction
       } catch let error as NSError {
           print("Unexpected error: \(error.debugDescription)")

packages/ironfish-native-module/rust_lib/src/lib.rs

@@ -339,6 +339,8 @@ pub fn create_note(params: NoteParams) -> Result<Vec<u8>, EnumError> {
 #[uniffi::export]
 pub fn create_transaction(
     transaction_version: u8,
+    transaction_fee: u64,
+    expiration_sequence: u32,
     spend_components: Vec<SpendComponents>,
     outputs: Vec<Vec<u8>>,
     spending_key: Vec<u8>,
@@ -394,13 +396,16 @@ pub fn create_transaction(
             .map_err(|e| EnumError::Error { msg: e.to_string() })?;
     }
 
+    transaction.set_expiration(expiration_sequence);
+
     let mut spending_key_data = Cursor::new(spending_key);
     let spending_key = ironfish::SaplingKey::read(&mut spending_key_data)
         .map_err(|e| EnumError::Error { msg: e.to_string() })?;
+
     let posted = transaction
-        .post(&spending_key, None, 1)
+        .post(&spending_key, None, transaction_fee)
         .map_err(|e| EnumError::Error { msg: e.to_string() })?;
-    let mut buffer = Vec::new();
+    let mut buffer: Vec<u8> = Vec::new();
     posted
         .write(&mut buffer)
         .map_err(|e| EnumError::Error { msg: e.to_string() })?;

packages/ironfish-native-module/src/index.ts

@@ -125,6 +125,8 @@ export function createNote({
 
 export function createTransaction(
   transactionVersion: number,
+  transactionFee: string,
+  expirationSequence: number,
   spendComponents: {
     note: string;
     witnessRootHash: string;
@@ -136,6 +138,8 @@ export function createTransaction(
 ): Promise<Uint8Array> {
   return IronfishNativeModule.createTransaction(
     transactionVersion,
+    transactionFee,
+    expirationSequence,
     { components: spendComponents },
     { outputs },
     spendingKey,

packages/mobile-app/data/wallet/wallet.ts

@@ -37,6 +37,10 @@ function assertStarted(state: WalletState): asserts state is StartedState {
 // TODO: Make confirmations configurable
 const CONFIRMATIONS = 2;
 
+// Used when calculating a transaction's expiration sequence by adding it
+// to the latest block sequence returned from the API.
+const EXPIRATION_DELTA = 20;
+
 export class Wallet {
   state: WalletState = { type: "STOPPED" };
   scanState: ScanState = { type: "IDLE" };
@@ -812,8 +816,15 @@ export class Wallet {
     if (spendingKey === null) {
       throw new Error("Spending key not found");
     }
+
+    const { sequence: latestSequence } =
+      await Blockchain.getLatestBlock(network);
+
     const result = await IronfishNativeModule.createTransaction(
       txnVersion,
+      // TODO: Implement proper transaction fees
+      "1",
+      latestSequence + EXPIRATION_DELTA,
       spendComponents,
       notes.map((note) => Uint8ArrayUtils.toHex(note)),
       Uint8ArrayUtils.fromHex(spendingKey),