[#2974] add more unittests

Author: Razvan Becheriu

src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc

@@ -1035,6 +1035,34 @@ TEST_F(CtrlChannelDhcpv4SrvTest, configTest) {
     CfgMgr::instance().clear();
 }
 
+// Verify that the "subnet4-select-test" command will do what we expect.
+TEST_F(CtrlChannelDhcpv4SrvTest, subnetSelectTest) {
+    createUnixChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet4-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet4-select-test command
+    std::string response;
+    sendUnixCommand(command_txt, response);
+
+    EXPECT_EQ("{ \"result\": 3, \"text\": \"no subnet selected\" }",
+              response);
+}
+
+// Verify that the "subnet4o6-select-test" command will do what we expect.
+TEST_F(CtrlChannelDhcpv4SrvTest, subnet4o6SelectTest) {
+    createUnixChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet4o6-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet4o6-select-test command
+    std::string response;
+    sendUnixCommand(command_txt, response);
+
+    EXPECT_EQ("{ \"result\": 3, \"text\": \"no subnet selected\" }",
+              response);
+}
+
 // This test verifies that the DHCP server handles version-get commands
 TEST_F(CtrlChannelDhcpv4SrvTest, getVersion) {
     createUnixChannelServer();

src/bin/dhcp4/tests/http_control_socket_unittest.cc

@@ -1663,6 +1663,62 @@ TEST_F(HttpsCtrlChannelDhcpv4Test, configTest) {
     CfgMgr::instance().clear();
 }
 
+// Verify that the "subnet4-select-test" command will do what we expect.
+TEST_F(HttpCtrlChannelDhcpv4Test, subnetSelectTest) {
+    createHttpChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet4-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet4-select-test command
+    std::string response;
+    sendHttpCommand(command_txt, response);
+
+    EXPECT_EQ("[ { \"result\": 3, \"text\": \"no subnet selected\" } ]",
+              response);
+}
+
+// Verify that the "subnet4-select-test" command will do what we expect.
+TEST_F(HttpsCtrlChannelDhcpv4Test, subnetSelectTest) {
+    createHttpChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet4-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet4-select-test command
+    std::string response;
+    sendHttpCommand(command_txt, response);
+
+    EXPECT_EQ("[ { \"result\": 3, \"text\": \"no subnet selected\" } ]",
+              response);
+}
+
+// Verify that the "subnet4o6-select-test" command will do what we expect.
+TEST_F(HttpCtrlChannelDhcpv4Test, subnet4o6SelectTest) {
+    createHttpChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet4o6-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet4o6-select-test command
+    std::string response;
+    sendHttpCommand(command_txt, response);
+
+    EXPECT_EQ("[ { \"result\": 3, \"text\": \"no subnet selected\" } ]",
+              response);
+}
+
+// Verify that the "subnet4o6-select-test" command will do what we expect.
+TEST_F(HttpsCtrlChannelDhcpv4Test, subnet4o6SelectTest) {
+    createHttpChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet4o6-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet4o6-select-test command
+    std::string response;
+    sendHttpCommand(command_txt, response);
+
+    EXPECT_EQ("[ { \"result\": 3, \"text\": \"no subnet selected\" } ]",
+              response);
+}
+
 // This test verifies that the DHCP server handles version-get commands.
 void
 BaseCtrlChannelDhcpv4Test::testGetVersion() {

src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc

@@ -1066,6 +1066,20 @@ TEST_F(CtrlChannelDhcpv6SrvTest, configTest) {
     CfgMgr::instance().clear();
 }
 
+// Verify that the "subnet6-select-test" command will do what we expect.
+TEST_F(CtrlChannelDhcpv6SrvTest, subnetSelectTest) {
+    createUnixChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet6-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet6-select-test command
+    std::string response;
+    sendUnixCommand(command_txt, response);
+
+    EXPECT_EQ("{ \"result\": 3, \"text\": \"no subnet selected\" }",
+              response);
+}
+
 // This test verifies that the DHCP server handles version-get commands
 TEST_F(CtrlChannelDhcpv6SrvTest, getVersion) {
     createUnixChannelServer();

src/bin/dhcp6/tests/http_control_socket_unittest.cc

@@ -1697,6 +1697,34 @@ TEST_F(HttpsCtrlChannelDhcpv6Test, configTest) {
     CfgMgr::instance().clear();
 }
 
+// Verify that the "subnet6-select-test" command will do what we expect.
+TEST_F(HttpCtrlChannelDhcpv6Test, subnetSelectTest) {
+    createHttpChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet6-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet6-select-test command
+    std::string response;
+    sendHttpCommand(command_txt, response);
+
+    EXPECT_EQ("[ { \"result\": 3, \"text\": \"no subnet selected\" } ]",
+              response);
+}
+
+// Verify that the "subnet6-select-test" command will do what we expect.
+TEST_F(HttpsCtrlChannelDhcpv6Test, subnetSelectTest) {
+    createHttpChannelServer();
+
+    string command_txt = "{ \"command\": \"subnet6-select-test\", \"arguments\": { \"classes\": [ \"foo\" ] } }";
+
+    // Send the subnet6-select-test command
+    std::string response;
+    sendHttpCommand(command_txt, response);
+
+    EXPECT_EQ("[ { \"result\": 3, \"text\": \"no subnet selected\" } ]",
+              response);
+}
+
 // This test verifies that the DHCP server handles version-get commands.
 void
 BaseCtrlChannelDhcpv6Test::testGetVersion() {