Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Respect STATIC_ROOT and MEDIA_ROOT from settings.py #1

Open
sHtev opened this issue Jun 23, 2015 · 1 comment
Open

Respect STATIC_ROOT and MEDIA_ROOT from settings.py #1

sHtev opened this issue Jun 23, 2015 · 1 comment

Comments

@sHtev
Copy link
Contributor

sHtev commented Jun 23, 2015

If STATIC_ROOT and MEDIA_ROOT are defined in settings.py, django-json-settings should not override them and force their re-definition in a local json file. Currently parsed django settings should be checked as well as the just-loaded env vars.

@chris-nlnz
Copy link

I agree (2 years later). It is a terrible choice to introduce "magic" variables; someone might find their STATIC_ROOT point to a /var/ somewhere even though it doesn't appear to be specified like that anywhere in their project. It could cost a developer a lot of time to figure out that it's your library that is messing with these settings quietly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants