fixed creepy tests

Author: ivanfoo

commands/configure.go

@@ -7,15 +7,15 @@ import (
 	"gopkg.in/ini.v1"
 )
 
-type CmdConfigure struct {
+type ConfigureCommand struct {
 	Alias string `short:"a" long:"alias" description:"role alias" required:"true"`
 	Arn   string `short:"r" long:"role" description:"arn role" required:"true"`
 	File  string `short:"f" long:"file" description:"alias file" default:"~/.mortadelo/alias"`
 
 	filePath string
 }
 
-func (c *CmdConfigure) Execute(args []string) error {
+func (c *ConfigureCommand) Execute(args []string) error {
 	c.filePath = expandPath(c.File)
 
 	err := c.createHome()
@@ -31,7 +31,7 @@ func (c *CmdConfigure) Execute(args []string) error {
 	return nil
 }
 
-func (c *CmdConfigure) createHome() error {
+func (c *ConfigureCommand) createHome() error {
 	path := filepath.Dir(c.filePath)
 	_, err := os.Stat(path)
 
@@ -47,7 +47,7 @@ func (c *CmdConfigure) createHome() error {
 	return nil
 }
 
-func (c *CmdConfigure) setAlias() error {
+func (c *ConfigureCommand) setAlias() error {
 	cfg, err := ini.LooseLoad(c.filePath)
 
 	if err != nil {

commands/configure_test.go

@@ -13,19 +13,21 @@ const (
 	testAliasFile = "/tmp/alias_tests"
 )
 
-func TestCmdConfigure(t *testing.T) {
-	cmd := &CmdConfigure{
+func TestConfigureCommand(t *testing.T) {
+	cmd := &ConfigureCommand{
 		Alias: testAlias,
 		Arn:   testArn,
+		File:  testAliasFile,
 	}
 
-	cmd.setupNewAlias(testAliasFile)
+	cmd.filePath = testAliasFile
+	cmd.setAlias()
 
 	cfg, _ := ini.LooseLoad(testAliasFile)
 	alias, _ := cfg.GetSection(testAlias)
 
 	if alias.Name() != testAlias {
-		t.Fatalf("Expected %s, got %s", testAlias, alias.Name)
+		t.Fatalf("Expected %s, got %s", testAlias, alias.Name())
 	}
 
 	arn, _ := alias.GetKey("arn")

mortadelo.go

@@ -12,7 +12,7 @@ func main() {
 	parser := flags.NewNamedParser("mortadelo", flags.Default)
 	parser.AddCommand("assume", "assume role", "", &commands.AssumeCommand{})
 	parser.AddCommand("clean", "clean generated files", "", &commands.CleanCommand{})
-	parser.AddCommand("configure", "configure roles alias file", "", &commands.CmdConfigure{})
+	parser.AddCommand("configure", "configure roles alias file", "", &commands.ConfigureCommand{})
 
 	_, err := parser.Parse()
 	if err != nil {