This repository has been archived by the owner on Oct 21, 2021. It is now read-only.
Add option to pass custom mattermost URL #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the regex `/^https:\/\/([^/]+\.mattermost|mattermost\.[^/]+|[^/]+\.mattermost\.[^/]+)/` doesn't work when one is using a custom url for their mattermost instance. This PR adds an options page where a user can configure their custom mattermost url. Fixes ivangabriele#156
eyalzek
changed the title
chrome complains about:
```
"browser_specific_settings": {
"gecko": {
"id": "{bf9b59a1-eccf-4f1c-88f5-a20ebebc4a0b}"
}
},
```
but this is necessary on firefox for using the storage api...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the regex
/^https:\/\/([^/]+\.mattermost|mattermost\.[^/]+|[^/]+\.mattermost\.[^/]+)/doesn't work when one is using a custom url for their mattermost instance. This PR adds an options page where a user can configure their custom mattermost url.Fixes #156
This probably still needs a documentation update. Also this doesn't work entirely at the moment since rollout is omitting necessary parentheses in the
ifcondition which results in:if (url === undefined || res.mattermost_url !== "" && !url.startsWith(res.mattermost_url) || res.mattermost_url === "" && !/^https:\/\/([^/]+\.mattermost|mattermost\.[^/]+|[^/]+\.mattermost\.[^/]+)/.test(url)) return;instead of:
if (url === undefined || (res.mattermost_url !== "" && !url.startsWith(res.mattermost_url)) || (res.mattermost_url === "" && !/^https:\/\/([^/]+\.mattermost|mattermost\.[^/]+|[^/]+\.mattermost\.[^/]+)/.test(url))) return;any tips as to how to resolve this are welcome, this is not my normal eco system.