Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] text.done seems to trim the icon #3

Closed
lopi-py opened this issue Jan 25, 2022 · 9 comments
Closed

[Config] text.done seems to trim the icon #3

lopi-py opened this issue Jan 25, 2022 · 9 comments
Labels
ui Related to formatting or positioning wontfix This will not be worked on

Comments

@lopi-py
Copy link

lopi-py commented Jan 25, 2022

image
fidget is trimming the right side of the icon, seems to only render the first character of text.done

Config

require("fidget").setup({
    text = {
        spinner = "arc",
        done = require("icons").check,
    },
})

icons.lua
image

@j-hui
Copy link
Owner

j-hui commented Jan 26, 2022

I'm unable to reproduce this problem using ASCII text. I see all characters rendered using done = "DONE":

image

I suspect that this is either an issue with Unicode, or with your font/terminal (I've encountered similar issues in the past where icons appear cut off). Can you paste the icon in this issue? What font/terminal emulator are you using?

@lopi-py
Copy link
Author

lopi-py commented Jan 26, 2022

Can you paste the icon in this issue? What font/terminal emulator are you using?

  • Icon: " "
  • Font: MesloLGS NF(nerd font)
  • Terminal: Windows Terminal(cmd.exe profile)

@lopi-py
Copy link
Author

lopi-py commented Jan 26, 2022

image
it works with letters, but if I put an icon, just takes the first character

@j-hui
Copy link
Owner

j-hui commented Jan 26, 2022

I'm unable to reproduce this error (on Alacritty running on NixOS with a completely different font):

image

I'm sorry but I'm not sure I can be of much help here.

That being said, there's definitely something fishy happening with that icon. I don't seem to be able to render it properly in my config:
image

Sorry this isn't ideal. Hopefully someone else will pick this up.. in the meantime, does the original check mark icon work for you?

@lopi-py
Copy link
Author

lopi-py commented Jan 26, 2022

Yes, the original check mark works

@j-hui j-hui added the help wanted Extra attention is needed label Jan 26, 2022
@lopi-py
Copy link
Author

lopi-py commented Jan 30, 2022

#23 fixed this but only if window.blend is set to 0

@j-hui
Copy link
Owner

j-hui commented Feb 1, 2022

That's really odd. There's something very fishy going on with how background highlights are working; disabling winblend seems to be a workaround but I'll have to investigate more.

@lopi-py
Copy link
Author

lopi-py commented Feb 1, 2022

Maybe could be a neovim problem, but I'm not sure

@Iskustvo
Copy link

Iskustvo commented Jan 6, 2023

Hi @lopi-py,

I'm pretty sure that the issue you described has nothing to do with this plugin, nor Neovim in general.
It's most likely issue with font or the terminal which you are using.
I have the same issue and so far I was avoiding it by adding one space after each icon, but when you need to interactively go over it (like in trouble.nvim) this really falls apart quickly 😄

Don't know which terminal you are using, but I'm on st and I can tell you that it doesn't work for me, while alacritty does.
Luckily, I found opened PR regarding the patch which claims to fix it, so we might get it truly fixed for st as well.

@j-hui j-hui added the ui Related to formatting or positioning label Jun 10, 2023
@j-hui j-hui closed this as completed Nov 10, 2023
@j-hui j-hui added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to formatting or positioning wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants