Era constraints, cardano-api-9.3.0.0 #211

j-mueller · 2024-10-06T14:54:50Z

Bump cardano-api to 9.3.0.0
Remove hard-coded ConwayEra in most places, use constraints from cardano-api
Update the Scripts.MatchingIndex example to use plutus v3

Thanks to @Swordlash for contributing a large part of the code

j-mueller · 2024-10-07T13:10:29Z

src/coin-selection/lib/Convex/CoinSelection.hs

  BalanceChanges (Map.singleton addr value)
 txOutChange _ = mempty

 data BalanceTxError era =
  ACoinSelectionError CoinSelectionError
  | ABalancingError (BalancingError era)
-  deriving stock (Show, Generic)
-  deriving anyclass (ToJSON, FromJSON)


Need to keep the JSON instances

j-mueller · 2024-10-07T13:14:08Z

src/mockchain/lib/Convex/MockChain.hs

@@ -432,35 +432,36 @@ instance Monad m => MonadBlockchain (MockchainT m) where
    st <- get
    NodeParams{npSystemStart, npEraHistory, npSlotLength} <- ask
    let slotNo = st ^. env . L.slot
-    utime <- either (throwError . FailWith) pure (slotToUtcTime npEraHistory npSystemStart slotNo)
+    -- FIXME: Propagate this to user?
+    let utime  = either (error . (<>) "MockchainT: slotToUtcTime failed ") id (slotToUtcTime npEraHistory npSystemStart slotNo)


Return Either as the third item

I thought about this some more. The utime :: UTCTime is the time of the current slot. So it's definitely less than the current wall clock time and it should always be possible to compute it. Returning the error (Either String UTCTime) would only make sense if the query was for some time in the future, for which we could get a PastHorizon error.

koslambrou

LGTM. The only thing is that we are going back from InAnyCardanoEra TxOut to TxOut era. IIRC, I did this so that we can use this with the chain-indexer which returns UTXOs from multiple eras.

Need to think about this. Maybe the solution would be to modify the chain-indexer so that it always converts UTXOs to the latest era, then we would not need InAnyCardanoEra.

koslambrou · 2024-10-08T13:14:49Z

src/base/lib/Convex/BuildTx.hs

+  => C.AddressInEra era -> C.Script lang -> a -> C.Value -> m ()
+createRefScriptInlineDatum addr script datum vl =
+  let dat = C.TxOutDatumInline C.babbageBasedEra (toHashableScriptData datum)
+  in createRefScriptBase addr script dat vl

 {-| same as payToPlutusV2Inline but also specify a datum -}


Update comment.

koslambrou · 2024-10-08T13:15:54Z

src/base/lib/Convex/BuildTx.hs

-payToPlutusV2InlineWithInlineDatum addr script datum vl =
-  let dat = C.TxOutDatumInline C.BabbageEraOnwardsConway (toHashableScriptData datum)
-  in payToPlutusV2InlineBase addr script dat vl
+createRefScriptInlineDatum :: forall a lang era m. (MonadBuildTx era m, Plutus.ToData a, C.IsBabbageBasedEra era, C.IsScriptLanguage lang)


To keep this consistent with the other names, maybe payToScriptWithRefScriptBase?

koslambrou · 2024-10-08T13:16:08Z

src/base/lib/Convex/BuildTx.hs

-payToPlutusV2Inline :: MonadBuildTx m => C.AddressInEra C.ConwayEra -> PlutusScript PlutusScriptV2 -> C.Value -> m ()
-payToPlutusV2Inline addr script = payToPlutusV2InlineBase addr script C.TxOutDatumNone
+createRefScriptNoDatum :: (MonadBuildTx era m, C.IsBabbageBasedEra era, C.IsScriptLanguage lang) => C.AddressInEra era -> C.Script lang -> C.Value -> m ()
+createRefScriptNoDatum addr script = createRefScriptBase addr script C.TxOutDatumNone

 {-| same as payToPlutusV2Inline but also specify an inline datum -}


Update comment.

koslambrou · 2024-10-09T09:14:14Z

src/base/lib/Convex/PlutusLedger.hs

@@ -3,6 +3,7 @@
 {-# LANGUAGE NamedFieldPuns   #-}
 {-# LANGUAGE TupleSections    #-}
 {-# LANGUAGE TypeApplications #-}
+{-# OPTIONS_GHC -Wno-deprecations #-}


Comment on when this can be removed?

koslambrou · 2024-10-09T09:57:14Z

src/coin-selection/lib/Convex/Query.hs

-newtype WalletAPIQueryT m a = WalletAPIQueryT{ runWalletAPIQueryT_ :: ReaderT ClientEnv m a }
-  deriving newtype (Functor, Applicative, Monad, MonadIO, MonadBlockchain, MonadLog, MonadTrans)
+newtype WalletAPIQueryT era m a = WalletAPIQueryT{ runWalletAPIQueryT_ :: ReaderT ClientEnv m a }
+  deriving newtype (Functor, Applicative, Monad, MonadIO, MonadBlockchain era, MonadLog)


We lost MonadTrans?

Thanks, brought it back in

koslambrou · 2024-10-09T09:57:37Z

src/coin-selection/lib/Convex/Query.hs

-  deriving anyclass (ToJSON, FromJSON)
+  | SubmitError (ValidationError era)
+  deriving stock Show
+  deriving anyclass Exception


We lost JSON instances here.

We keep the original ValidationError era instead of the string. We could still convert to JSON after showing the BalanceAndSubmitError, but now we can get some more information from matching on the constructor of ValidationError

koslambrou · 2024-10-09T10:10:59Z

src/base/lib/Convex/Utxos.hs

@@ -115,244 +111,97 @@ type AddressCredential = Shelley.PaymentCredential StandardCrypto

 {-| A set of unspent transaction outputs
 -}
-newtype UtxoSet ctx a = UtxoSet{ _utxos :: Map C.TxIn (C.InAnyCardanoEra (C.TxOut ctx), a) }
+newtype UtxoSet ctx era a = UtxoSet{ _utxos :: Map C.TxIn (C.TxOut ctx era, a) }


Not sure the impact of this change in our other repo, but the advantage of using InAnyCardanoEra is that we can have utxos from multiple eras inside that type. Right now, you are restricted to a single era.

Yep I brought back the InAnyCardanoEra type for UTxOs

When is this ever used / needed?

j-mueller · 2024-10-14T08:16:33Z

I added two tickets to address some work that needs to be done separately:

j-mueller mentioned this pull request Oct 6, 2024

De-hardcode ConwayEra, parametrise & use IsBabbageBasedEra / IsConwayBasedEra where applicable #206

Closed

j-mueller changed the title ~~Era constraints~~ Era constraints, cardano-api-9.3.0.0 Oct 7, 2024

j-mueller requested a review from koslambrou October 7, 2024 12:37

j-mueller commented Oct 7, 2024

View reviewed changes

koslambrou approved these changes Oct 9, 2024

View reviewed changes

j-mueller added 11 commits October 14, 2024 10:37

WIP era constraints

ffd1b0d

Add era parameter

128fc08

Fix tests in convex-coin-selection

6f081a1

Better error handling in property test

87bc959

Update README

95dd0c8

Update nix flake; Scripts improvements

c924257

Update node build in CI

3d4392f

Bring back InAnyCardanoEra for UTxOs

793bd5d

Bring back JSON instances

d1382cb

Add link to deprecation flags

20289a0

Fix test

344a8f6

j-mueller force-pushed the era-constraints branch from 28a2caa to 344a8f6 Compare October 14, 2024 08:41

Update comments

0ca4662

j-mueller merged commit 1141f7f into main Oct 14, 2024
5 checks passed

j-mueller deleted the era-constraints branch October 14, 2024 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Era constraints, cardano-api-9.3.0.0 #211

Era constraints, cardano-api-9.3.0.0 #211

j-mueller commented Oct 6, 2024 •

edited

Loading

j-mueller Oct 7, 2024

j-mueller Oct 7, 2024

j-mueller Oct 14, 2024

koslambrou left a comment

koslambrou Oct 8, 2024

koslambrou Oct 8, 2024

koslambrou Oct 8, 2024

koslambrou Oct 9, 2024

koslambrou Oct 9, 2024

j-mueller Oct 14, 2024

koslambrou Oct 9, 2024

j-mueller Oct 14, 2024

koslambrou Oct 9, 2024

j-mueller Oct 14, 2024

Swordlash Oct 17, 2024

j-mueller commented Oct 14, 2024

Era constraints, cardano-api-9.3.0.0 #211

Era constraints, cardano-api-9.3.0.0 #211

Conversation

j-mueller commented Oct 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koslambrou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

j-mueller commented Oct 14, 2024

j-mueller commented Oct 6, 2024 •

edited

Loading