How to set database/sql pool configuration when using stdlib.OpenDBFromPool(pool)

[aeneasr]

When using

db := stdlib.OpenDBFromPool(pool)

it's not immediately clear to me how the underlying db connection needs to be configured. At the moment, we do this:

			db := stdlib.OpenDBFromPool(pool)
			db.SetMaxOpenConns(0) // pgxpool does the pooling for us.

			details := c.Details()
			if details.ConnMaxLifetime > 0 { // standard stdlib config
				db.SetConnMaxLifetime(details.ConnMaxLifetime)
			}

			if details.ConnMaxIdleTime > 0 { // standard stdlib config
				db.SetConnMaxIdleTime(details.ConnMaxIdleTime)
			}

			return sqlx.NewDb(db, dialect), pool, nil

I'm not sure if the calls to db.Set* are correct. Additionally, the pgxpool emits a couple of separate statistics to the database/sql stats. Does it make sense to monitor both stats or can we safely use the pgxpool stats for monitoring and discard database/sql stats?

Thank you very much for any answer and this amazing project!

[lzakharov]

When using stdlib.OpenDBFromPool, the *sql.DB only works as an adapter for pgxpool.Pool. So you should configure all parameters for pgxpool.Pool via pgxpool.Config. The same for the stats - connections live only in pgxpool.Pool, so you have to use it’s stats.

Also you can omit db.SetMaxOpenConns(0), cause it automatically configured on stdlib.OpenDBFromPool.

[aeneasr]

Thank you so much for your reply!