dismissOnHardwareBackPress = false and dismissOnTouchOutside = false not working

[boliveira]

Hi,

I tried to show a dialog with DialogManager.show with dismissOnHardwareBackPress = false and dismissOnTouchOutside = false and it's not working, it's dismissing anyway.
Took a look at the code and the dismissOnHardwareBackPress is not passed to PopupDialog instance on DialogComponent render, and on Dialog.js there is a property closeOnTouchOutside that exists for backwards compatibility but it's value is by default true and it ignores the dismissOnTouchOutside value.

[jacklam718]

@boliveira
Did you set haveOverlay = false? because if haveOverlay is false then dismissOnTouchOutside won't work.

[boliveira]

No, haveOverlay is true, I checked that. I ended up changing Dialog.js code to remove the close*** props and changed DialogComponent.js to pass dismissOnHardwareBackPress to PopupDialog and then it worked.

[jacklam718]

@boliveira Can you try version v0.1.11 thanks. if there are any problem please let me know. Thanks a lot.

[boliveira]

@jacklam718 , tested version v0.1.11 and it works now. Thank you very much!