Is OTLP bytesValue possibly missing

[dimaqq]

I'm looking at this code:

jaeger/model/converter/thrift/jaeger/from_domain.go

Lines 36 to 90 in 3c135b1

	func (domainToJaegerTransformer) keyValueToTag(kv *model.KeyValue) *jaeger.Tag {
	if kv.VType == model.StringType {
	stringValue := kv.VStr
	return &jaeger.Tag{
	Key: kv.Key,
	VType: jaeger.TagType_STRING,
	VStr: &stringValue,
	}
	}
	if kv.VType == model.Int64Type {
	intValue := kv.Int64()
	return &jaeger.Tag{
	Key: kv.Key,
	VType: jaeger.TagType_LONG,
	VLong: &intValue,
	}
	}
	if kv.VType == model.BinaryType {
	binaryValue := kv.Binary()
	return &jaeger.Tag{
	Key: kv.Key,
	VType: jaeger.TagType_BINARY,
	VBinary: binaryValue,
	}
	}
	if kv.VType == model.BoolType {
	boolValue := kv.Bool()
	return &jaeger.Tag{
	Key: kv.Key,
	VType: jaeger.TagType_BOOL,
	VBool: &boolValue,
	}
	}
	if kv.VType == model.Float64Type {
	floatValue := kv.Float64()
	return &jaeger.Tag{
	Key: kv.Key,
	VType: jaeger.TagType_DOUBLE,
	VDouble: &floatValue,
	}
	}
	errString := fmt.Sprintf("No suitable tag type found for: %#v", kv.VType)
	errTag := &jaeger.Tag{
	Key: "Error",
	VType: jaeger.TagType_STRING,
	VStr: &errString,
	}
	return errTag
	}

Which looks like AnyValue parsing for OTLP.

It seems that the bytesValue is missing there.

External links:

• bytesValue added to OTLP proto message 3 years ago: Add bytes (binary) as a data type to AnyValue open-telemetry/opentelemetry-proto#297
• an attempt to encode bytesValue in OTEL SDK for Python: Support type bytes for OTLP AnyValue encoding open-telemetry/opentelemetry-python#4118

[dimaqq]

On the second look, there's something called binaryValue.. so maybe?
As you can see I'm pretty confused... help anyone?

[dosubot[bot]]

Hey there, @dimaqq! 👋 I'm here to help you out with any bugs or questions you have while waiting for a human maintainer. I'm a bot that can assist with problem-solving and contributing.

The Jaeger codebase does have a mapping for bytesValue in its handling of OTLP AnyValue types. The AnyValue struct in Jaeger includes a BytesValue type, which suggests that there is support for bytesValue ^[1]. However, the specific section of the from_domain.go file you referenced does not seem to handle bytesValue, which might indicate a gap in that particular conversion logic.

Regarding binaryValue, it seems there might be some confusion. In the context of Jaeger and OTLP, bytesValue is the relevant type for handling binary data. If binaryValue is mentioned elsewhere, it might be a different implementation or naming convention, but the standard OTLP type is bytesValue.

If the from_domain.go file is missing handling for bytesValue, it could be an area that needs updating to ensure full compatibility with the OTLP specification.

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other}

[yurishkuro]

converter/thrift/jaeger translates legacy Jaeger Thrift to (also legacy) Jaeger domain model (based on Protobuf). Neither have anything to do with OTLP. The translation from OTLP lives in otel-collector-contrib repo.